Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI (Buildkite): in the experimental asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) #42229

Merged
merged 5 commits into from
Sep 13, 2021
Merged

CI (Buildkite): in the experimental asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) #42229

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f58cc59
CI (Buildkite): disable the experimental `asan` job
DilumAluthge Sep 13, 2021
7ffad1e
Apply suggestions from code review
DilumAluthge Sep 13, 2021
aa05185
Keep running the `asan` job
DilumAluthge Sep 13, 2021
39eb16d
Comment out the "soft-fail" lines
DilumAluthge Sep 13, 2021
b8a3ec6
Delete the commented-out "soft-fail" lines
DilumAluthge Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .buildkite/pipelines/experimental/misc/sanitizers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@ steps:
# `contrib/check-asan.jl` needs a `julia` binary:
- JuliaCI/julia#v1:
version: 1.6
timeout_in_minutes: 120
# notify:
# - github_commit_status:
# context: "asan"
commands: |
echo "--- Build julia-debug with ASAN"
contrib/asan/build.sh ./tmp/test-asan -j$${JULIA_NUM_CORES} debug
echo "--- Test that ASAN is enabled"
contrib/asan/check.jl ./tmp/test-asan/asan/usr/bin/julia-debug
timeout_in_minutes: 120
# notify: # TODO: uncomment this line
# - github_commit_status: # TODO: uncomment this line
# context: "asan" # TODO: uncomment this line