Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "Test spawning a lot of tasks" on non-Linux #43072

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

tkf
Copy link
Member

@tkf tkf commented Nov 14, 2021

This re-enables the bug reproducer test #42975 spawn and wait *a lot* of tasks in @profile (fixed in #42978) for non-Linux platforms so that people using Windows, macOS, and FreeBSD can pick it up.

Ref: #42978 (comment)

@tkf tkf added bug Indicates an unexpected problem or unintended behavior system:freebsd Affects only FreeBSD system:mac Affects only macOS multithreading Base.Threads and related functionality system:windows Affects only Windows profiler labels Nov 14, 2021
@tkf
Copy link
Member Author

tkf commented Nov 14, 2021

It looks like macOS and FreeBSD are actually fine? Or maybe increasing the timeout bf070fc helped?

https://build.julialang.org/#/builders/26/builds/5861
https://build.julialang.org/#/builders/78/builds/5216

@tkf tkf removed system:mac Affects only macOS system:freebsd Affects only FreeBSD labels Nov 14, 2021
@tkf
Copy link
Member Author

tkf commented Nov 14, 2021

@tkf tkf removed bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows labels Nov 14, 2021
@tkf
Copy link
Member Author

tkf commented Nov 14, 2021

@vtjnash Since the main fix 17a70d2 in #42978 was OS-agnostic, maybe #42978 was enough for all OSes? Or do you want to do something equivalent to pthread_cond_timedwait e001bc7 in Windows and macOS?

@vtjnash
Copy link
Member

vtjnash commented Nov 15, 2021

The usage of pthread_cond_timedwait is just because the linux kernel is unreliable here. The other kernels don't have that problem and therefore that isn't needed.

@vtjnash vtjnash marked this pull request as ready for review November 15, 2021 19:27
@vtjnash vtjnash added the test This change adds or pertains to unit tests label Nov 15, 2021
@tkf tkf merged commit 4b99bc8 into JuliaLang:master Nov 15, 2021
@tkf tkf deleted the non-linux-spawnmany branch November 15, 2021 20:37
@DilumAluthge
Copy link
Member

DilumAluthge commented Nov 18, 2021

@tkf @vtjnash I'm seeing this test fail on CI intermittently, but (AFAICT) only on Windows.

Could we add an if !Sys.iswindows(), or something like that?

@DilumAluthge
Copy link
Member

Here's an example failure on tester_win64: https://build.julialang.org/#/builders/65/builds/5532

@tkf
Copy link
Member Author

tkf commented Nov 18, 2021

Yeah, I think we need to disable this. I just opened #43125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multithreading Base.Threads and related functionality profiler test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants