-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable "Test spawning a lot of tasks" on Windows #43125
Conversation
Instead of disabling completely, it might be fine to just dump all the output to the log. Then, the next time we see this failure in CI, we can actually collect some information on why it failed. |
I also don't object to disabling it completely on Windows. Either approach is fine. |
Yeah, maybe we can just pull only the first commit. I guess it'd be easier to notice the failure if the CI actually fails. |
Let's pull in the first commit via #43126 first. Then I'll prepare a patch to disable the Windows test (without the logging message #43125 (comment)) in this PR. This way, we can disable the Windows test with a few clicks. |
Never mind, this is pretty reproducible. I get the log output
in https://build.julialang.org/#/builders/65/builds/5543 3221225477 is Note that BTW, #32938 would have been helpful for noticing this from the vanilla test output. |
Let's go ahead and give this a try? |
So, there seem to be a failure with Let's skip the tests on Windows. Decreasing |
* Don't hide output from spawnmany test script * Disable "Test spawning a lot of tasks" on Windows * If `!success(proc) || timeout`, print a variety of debugging data Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
* Don't hide output from spawnmany test script * Disable "Test spawning a lot of tasks" on Windows * If `!success(proc) || timeout`, print a variety of debugging data Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
This patch disables the known failure #43124 on Windows for now.
Ref: #43072 (comment)