Base.GIT_VERSION_INFO: record the Buildkite commit that was used to build Julia
#43073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
building
DilumAluthge
commented
Nov 14, 2021
|
Bump @staticfloat |
DilumAluthge
force-pushed
the
dpa/version-git-buildkite-commit
branch
from
5d1c1eb
to
cf0b519
Compare
|
Bump @staticfloat |
staticfloat
approved these changes
Nov 21, 2021
…i.e. remove the `:?` suffix)
DilumAluthge
force-pushed
the
dpa/version-git-buildkite-commit
branch
from
ad2cbd1
to
9212bcf
Compare
DilumAluthge
added
backport 1.6
DilumAluthge
removed
the
merge me
fredrikekre
reviewed
Nov 22, 2021
| @@ -82,6 +84,16 @@ if [ -z "$fork_master_timestamp" ]; then | |||
| fork_master_timestamp="0" | |||
| fi | |||
|
|
|||
| build_system_directory="../.buildkite" | |||
| if [[ -d "${build_system_directory}/.git" ]]; then | |||
There was a problem hiding this comment.
This is a /bin/sh script so this errors.
There was a problem hiding this comment.
Which part errors? I just ran the following locally inside /bin/sh, and it seemed to work fine for me.
build_system_directory="../.buildkite"
if [[ -d "${build_system_directory}/.git" ]]; then
echo "foo"
else
echo "bar"
fi
There was a problem hiding this comment.
Probably /bin/sh is bash for you then. On Ubuntu, at least, /bin/sh is dash by default, and there you get
.../version_git.sh: 88: [[: not found
| build_system_commit=$(git -C "${build_system_directory}" rev-parse HEAD) | ||
| build_system_commit_short=$(git -C "${build_system_directory}" rev-parse --short HEAD) | ||
| else | ||
| echo "Warning: The build system directory does not exist or is not a Git repo: ${build_system_directory}" >&2 |
29 tasks
29 tasks
15 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.