Fix shell syntax in version_git.sh and remove warning. #43196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
approved these changes
Nov 23, 2021
|
In theory, we could look for the presence of the |
|
Who will read that warning though? Will CI even start if that directory doesn't exist? |
|
Yeah that's a good point. You'd only see the warning if you checked the CI logs. But as you point out, if the |
|
It's also not really worth trying to stuff too much CI-specific stuff into this shell script in the first place. So I think just removing the warning is fine. |
DilumAluthge
added
backport 1.6
KristofferC
pushed a commit
that referenced
this pull request
Dec 2, 2021
(cherry picked from commit 99f6558)
29 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 2, 2021
(cherry picked from commit 99f6558)
KristofferC
pushed a commit
that referenced
this pull request
Dec 2, 2021
(cherry picked from commit 99f6558)
15 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 99f6558)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.