Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use name in source module when importing an aliased binding #43291

Merged
merged 2 commits into from
Feb 28, 2022
Merged

use name in source module when importing an aliased binding #43291

merged 2 commits into from
Feb 28, 2022

Conversation

Pangoraw
Copy link
Contributor

@Pangoraw Pangoraw commented Dec 1, 2021 •
edited
Loading

This solves the following problem:

julia> module A
           import Base.identity as id
       end
Main.A

julia> import .A.id

julia> id
ERROR: UndefVarError: id not defined

The binding name is used to lookup in nb->owner, thus it should be the name in b->owner.

Fixes #43290
Fixes #42808

@Pangoraw Pangoraw mentioned this pull request Jan 28, 2022
Closed
@Pangoraw
use name in source module when importing an aliased binding
1eea8cc 
This solves the following problem:
```julia
julia> module A
           import Base.identity as id
       end
Main.A

julia> import .A.id

julia> id
ERROR: UndefVarError: id not defined
```
simeonschaub
simeonschaub approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the wait

@simeonschaub simeonschaub added backport 1.7 backport 1.8 Change should be backported to release-1.8 backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug merge me PR is reviewed. Merge when all tests are passing modules labels Feb 27, 2022
@vchuravy vchuravy merged commit 2338f5d into JuliaLang:master Feb 28, 2022
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 28, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
@Pangoraw @simeonschaub @staticfloat
use name in source module when importing an aliased binding (JuliaLan…
5964c04 
…g#43291)



Co-authored-by: Simeon David Schaub <schaub@mit.edu>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@Pangoraw @simeonschaub @LilithHafner
use name in source module when importing an aliased binding (JuliaLan…
3784e93 
…g#43291)



Co-authored-by: Simeon David Schaub <schaub@mit.edu>
@Pangoraw Pangoraw deleted the binding_name branch March 10, 2022 15:30
KristofferC pushed a commit that referenced this pull request Mar 15, 2022
@Pangoraw
use name in source module when importing an aliased binding (#43291)
8a032f7 
Co-authored-by: Simeon David Schaub <schaub@mit.edu>
(cherry picked from commit 2338f5d)
@KristofferC KristofferC mentioned this pull request Mar 15, 2022
Closed
14 tasks
KristofferC pushed a commit that referenced this pull request Mar 15, 2022
@Pangoraw
use name in source module when importing an aliased binding (#43291)
e8afcb2 
Co-authored-by: Simeon David Schaub <schaub@mit.edu>
(cherry picked from commit 2338f5d)
@KristofferC KristofferC mentioned this pull request Mar 15, 2022
Merged
50 tasks
KristofferC pushed a commit that referenced this pull request Mar 16, 2022
@Pangoraw @KristofferC
use name in source module when importing an aliased binding (#43291)
0f04c8e 
Co-authored-by: Simeon David Schaub <schaub@mit.edu>
(cherry picked from commit 2338f5d)
KristofferC pushed a commit that referenced this pull request Mar 16, 2022
@Pangoraw
use name in source module when importing an aliased binding (#43291)
426a4ad 
Co-authored-by: Simeon David Schaub <schaub@mit.edu>
(cherry picked from commit 2338f5d)
@KristofferC KristofferC mentioned this pull request Mar 18, 2022
Merged
17 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Mar 21, 2022
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@Pangoraw @KristofferC
use name in source module when importing an aliased binding (#43291)
e9e5450 
Co-authored-by: Simeon David Schaub <schaub@mit.edu>
(cherry picked from commit 2338f5d)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
40 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@Pangoraw @staticfloat
use name in source module when importing an aliased binding (#43291)
3365bc5 
Co-authored-by: Simeon David Schaub <schaub@mit.edu>
(cherry picked from commit 2338f5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonschaub simeonschaub simeonschaub approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aliases imported from another module are undefined A bug with using M: a as b
5 participants
@Pangoraw @simeonschaub @vchuravy @KristofferC @DilumAluthge