Support LLVM 14 (upstream Git main)
#43628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Jan 3, 2022
Compiles against llvm/llvm-project#2ec3ca747732, with some of our unmerged local patches from 13.x still required. Unfortunately, there is quite a bit of fallout from the various attribute API renames. I chose to introduce some function shims to separate out all the preprocessor #if clutter.
vchuravy
approved these changes
Jan 3, 2022
vchuravy
added
compiler:codegen
DilumAluthge
removed
the
merge me
|
Thanks for the speedy review! |
vtjnash
reviewed
Jan 7, 2022
vtjnash
reviewed
Jan 7, 2022
| @@ -1951,7 +1947,7 @@ jl_cgval_t function_sig_t::emit_a_ccall( | |||
| // something alloca'd above is SSA | |||
| if (static_rt) | |||
| return mark_julia_slot(result, rt, NULL, tbaa_stack); | |||
| result = ctx.builder.CreateLoad(result); | |||
| result = ctx.builder.CreateLoad(cast<PointerType>(result->getType())->getElementType(), result); | |||
There was a problem hiding this comment.
getElementType is deprecated and must not be used in new code
There was a problem hiding this comment.
This would require some restructuring of emit_a_ccall – I'd rather leave this to somebody familiar with the code once getElementType is actually removed.
vtjnash
reviewed
Jan 7, 2022
vtjnash
reviewed
Jan 7, 2022
vtjnash
reviewed
Jan 7, 2022
|
#43721 removes some of the |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Compiles against llvm/llvm-project#2ec3ca747732, with some of our unmerged local patches from 13.x still required. Unfortunately, there is quite a bit of fallout from the various attribute API renames. I chose to introduce some function shims to separate out all the preprocessor #if clutter.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Compiles against llvm/llvm-project#2ec3ca747732, with some of our unmerged local patches from 13.x still required. Unfortunately, there is quite a bit of fallout from the various attribute API renames. I chose to introduce some function shims to separate out all the preprocessor #if clutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiles against llvm/llvm-project@2ec3ca747732, with some of our unmerged local patches from 13.x still required to fix some miscompilations, etc.
Unfortunately, there is quite a bit of fallout from the various attribute API renames. I chose to introduce some function shims to separate out all the preprocessor #if clutter.
Some small refactorings were also necessary as some LLVM APIs now explicitly require the pointer element type in preparation for opaque pointers.
There should be no functional changes on older versions; compilation checked against the BinaryBuilder LLVM 12 that the Makefiles pull in by default.
I ported Julia to LLVM
mainfor my work on darwin-aarch64, but even if we might end up back-porting all the components required for that, @vchuravy mentioned on Slack that havingmainsupport in the main repository would still be interesting.