codegen: Avoid some uses of PointerType::getElementType() #43721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadlinger
force-pushed
the
avoid-getelementtype
branch
2 times, most recently
from
fb14795 to
e4a1e7b
Compare
getElementType() will eventually go away with the LLVM switch to opaque pointers. The assertion in gen_cfun_wrapper is still checked within CreateAlignedLoad.
dnadlinger
force-pushed
the
avoid-getelementtype
branch
from
e4a1e7b to
2887d25
Compare
|
The buildbot/tester_linuxaarch64 failure is unrelated – seems like this might be more or less the same issue that is also plaguing Darwin (see #43664). |
|
The buildbot/tester_linux64 failure also seems like a flaky Distributed test, but I don't have permission to trigger a rebuild. |
Actually it is in FileWatching.jl |
vchuravy
approved these changes
Jan 10, 2022
You are right, of course – I was looking at the wrong part of the backtrace. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…43721) getElementType() will eventually go away with the LLVM switch to opaque pointers. The assertion in gen_cfun_wrapper is still checked within CreateAlignedLoad.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…43721) getElementType() will eventually go away with the LLVM switch to opaque pointers. The assertion in gen_cfun_wrapper is still checked within CreateAlignedLoad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getElementType()will eventually go away with the LLVM switch to opaque pointers.The assertion in
gen_cfun_wrapperis still checked withinCreateAlignedLoad.As suggested by @vtjnash in #43628. More work will need to be done to completely remove
PointerType::getElementType()from our codebase, e.g. usinggetWithSamePointeeTypefor the address space passes, etc.