Fix segfault in Diagonal * OffsetMatrix

[jishnub]

This fixes a segfault in Diagonal * OffsetMatrix if the axes of the offset matrix are not 1-based. On master, the check was for sizes of the inputs, and not axes. I've added appropriate require_one_based_indexing checks.

This should be back-ported to 1.8.

[KristofferC]

I don't think this is applicable to 1.6 since the dispatch there seems to include this check:

julia/stdlib/LinearAlgebra/src/diagonal.jl

Lines 199 to 214 in aafae8a

	(*)(A::AbstractMatrix, D::Diagonal) =
	rmul!(copyto!(similar(A, promote_op(*, eltype(A), eltype(D.diag)), size(A)), A), D)
	(*)(D::Diagonal, A::AbstractMatrix) =
	lmul!(D, copyto!(similar(A, promote_op(*, eltype(A), eltype(D.diag)), size(A)), A))
	function rmul!(A::AbstractMatrix, D::Diagonal)
	require_one_based_indexing(A)
	A .= A .* permutedims(D.diag)
	return A
	end
	function lmul!(D::Diagonal, B::AbstractVecOrMat)
	require_one_based_indexing(B)
	B .= D.diag .* B
	return B
	end