Backports for 1.8-rc2/1.8.0 #45491

KristofferC · 2022-05-28T06:42:50Z

Backported PRs:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

We have `typeof(Union{}) == Type{Union{}}`, but were treating them differently in the calculation of `isdispatchtuple`. The compiler expects `isdispatchtuple` to commute with type equality in various places, so try to make this consistent. Fixes #45347 (cherry picked from commit a37dd16)

(cherry picked from commit a5438f9)

This new build doesn't depend on Kerberos Co-authored-by: Mosè Giordano <mose@gnu.org> (cherry picked from commit 28d9326)

…e inlining" This reverts commit 8bca2f4.

…#45534)

ufechner7 · 2022-06-02T07:23:28Z

JuliaLang/Pkg.jl#2990 should be included. This fixes a very annoying bug which is still present in 1.8.0-rc1

KristofferC · 2022-06-02T08:51:03Z

Yep, thanks for the pointer.

KristofferC · 2022-06-02T13:28:38Z

Eh, that commit is already included from what I can see. So could you elaborate a bit on what the issue is?

ufechner7 · 2022-06-02T20:32:56Z

See:
https://discourse.julialang.org/t/inconsistant-message-in-julia-1-8-rc1/82104

When running "test" in package manager I get the message:
"Info Packages marked with ⌃ and ⌅ have new versions available, but those with ⌅ cannot be upgraded. To see why use status --outdated", but if I run "status --outdated" nothing is shown...

Which is this bug: JuliaLang/Pkg.jl#2989 which is closed, but still present in 1.8.0-rc1

(cherry picked from commit 21e5a26)

(cherry picked from commit 6ea9034)

(cherry picked from commit 6f8860c)

(cherry picked from commit 0a55a8e)

* diagonal*offset matrix should throw (cherry picked from commit 172bddc)

Since the `data` argument possibly does not come from the current configuration, we should not use `nthreads` here either to filter out possibly significant data. (cherry picked from commit b46c14e)

KristofferC · 2022-06-08T12:03:57Z

@nanosoldier runtests(ALL, vs = ":release-1.8")

KristofferC · 2022-06-08T12:04:05Z

@nanosoldier runbenchmarks(ALL, vs = ":release-1.8")

nanosoldier · 2022-06-08T19:13:15Z

Something went wrong when running your job:

NanosoldierError: error when preparing/pushing to report repo: failed process: Process(setenv(`git push`; dir="/nanosoldier/workdir/NanosoldierReports"), ProcessExited(1)) [1]

Unfortunately, the logs could not be uploaded.

nanosoldier · 2022-06-08T20:26:27Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

…5615) `is_foldable` should be more aligned with `Base.@assume_effects`. This should be backported to 1.8 also.

vtjnash · 2022-06-09T19:13:04Z

https://github.com/JuliaCI/NanosoldierReports/blob/master/benchmark/by_hash/01d6fae_vs_6368fdc/report.md

This reverts commit eb82f18.

KristofferC · 2022-06-13T07:45:31Z

@nanosoldier runtests(["AlphaStableDistributions", "AutomotiveVisualization", "Bonsai", "ConScape", "ControlSystemIdentification", "DASKR", "GeoArrays", "HighDimPDE", "InvertibleNetworks", "MKL", "OteraEngine", "OutlierDetectionData", "PNGFiles", "ParameterEstimateScatterPlots", "Reactive", "SeisNoise", "ShipMMG"], vs = ":release-1.8")

nanosoldier · 2022-06-13T20:41:47Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

I've omitted `invpcid` feature since it's clearly omitted for other CPU's. Fixes #45657 (cherry picked from commit 3f047f7)

KristofferC · 2022-06-22T21:45:19Z

@nanosoldier runtests(ALL, vs = ":release-1.8", buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"], vs_buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"])

nanosoldier · 2022-06-23T08:19:48Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

KristofferC · 2022-07-04T09:56:24Z

@nanosoldier runtests(["AlphaStableDistributions", "ApproxFunOrthogonalPolynomials", "AugmentedGaussianProcesses", "BifurcationInference", "Cambrian", "EclipsingBinaryStars", "ElasticArrays", "EnsembleKalmanProcesses", "FHIRClient", "FieldTracer", "GibbsSeaWater", "GitCommand", "Hashpipe", "HorseML", "InferOpt", "InformationGeometry", "MCPhyloTree", "MIToS", "MPSKit", "MemPool", "MultivariatePolynomials", "NNlib", "NavAbilitySDK", "NormalSplines", "PhaseSpaceTools", "PotentialFlow", "ProgressiveHedging", "Quiqbox", "RetroCap", "SpinDoctor", "SummationByPartsOperators"], vs = ":release-1.8")

KristofferC · 2022-07-04T09:58:04Z

Should have been run with assertions:

@nanosoldier runtests(["AlphaStableDistributions", "ApproxFunOrthogonalPolynomials", "AugmentedGaussianProcesses", "BifurcationInference", "Cambrian", "EclipsingBinaryStars", "ElasticArrays", "EnsembleKalmanProcesses", "FHIRClient", "FieldTracer", "GibbsSeaWater", "GitCommand", "Hashpipe", "HorseML", "InferOpt", "InformationGeometry", "MCPhyloTree", "MIToS", "MPSKit", "MemPool", "MultivariatePolynomials", "NNlib", "NavAbilitySDK", "NormalSplines", "PhaseSpaceTools", "PotentialFlow", "ProgressiveHedging", "Quiqbox", "RetroCap", "SpinDoctor", "SummationByPartsOperators"], vs = ":release-1.8", buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"], vs_buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"])

This fixes hundreds of invalidations from Unitful. Co-authored by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>

`@time` now shows if any of the compilation time was spent recompiling invalidated methods. The new percentage is % of the compilation time, not the total execution time. (cherry picked from commit 7074f04)

(cherry picked from commit 9320fba)

This is theoretically okay, but unlikely to be intended ever. (cherry picked from commit d81724a)

Does not explicitly close issue #45704, as perhaps the deserialized module should still be valid after the replacement warning. (cherry picked from commit ad8893b)

Ensures we do not get easily wedged into bad states. (cherry picked from commit d0e28af)

Regressions introduced by #45607 (cherry picked from commit 239a1f2)

(cherry picked from commit b49a1b4)

fix #44705 (cherry picked from commit 4115686)

…func` (#44896) Follows up #44725. (cherry picked from commit 0deb326)

(cherry picked from commit 4f1c68e)

(cherry picked from commit 9b83dd8)

…ation (#45746) * Bump LBT to 5.1.1 * Use DESTDIR to install into * Update LBT checksums (cherry picked from commit 1d78265)

(cherry picked from commit 1f99ee9)

When egal objects contain identical typevars with different environments, the resulting subtyping might not be so obvious. Fix #45703 (cherry picked from commit 8ccf2d6)

This prevents a compiler warning on some systems (cherry picked from commit 05eb153)

nanosoldier · 2022-07-05T04:29:36Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

nanosoldier · 2022-07-05T05:47:32Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

* Bug fix for `max_collect_interval` computation (#45727) Currently constrained to `totalmem / ncores / 2` for `_P64` which results in a very short collect interval when you're running with a smaller number of threads on a machine with many cores. Changes this to `totalmem / nthreads / 2` which, for two of our tests, resulted in 40% and 60% runtime reduction (!!) as well as GC time reduction from 46% to 10% and 64% to 11%. * Move GC init after threading init To allow use of `jl_n_threads` in GC initialization.

Keno and others added 8 commits May 28, 2022 08:24

Do not set MCPU on Apple Silicon (#45409)

25122e4

(cherry picked from commit a5438f9)

Update LibCURL to 7.83.1 (#45443)

0769bb5

This new build doesn't depend on Kerberos Co-authored-by: Mosè Giordano <mose@gnu.org> (cherry picked from commit 28d9326)

Revert "fix #45440, improve the robustness of concrete-evaled callsit…

bde7223

…e inlining" This reverts commit 8bca2f4.

follow #45440, add assertion to check concrete-eval call is compileable

801458d

tweak NEWS.md

8f1a4ce

note @inline inside body usage (#45531)

32106ab

rename Base.@assume_effects :total_may_throw setting to :foldable (…

4c65dce

…#45534)

KristofferC and others added 7 commits June 7, 2022 16:03

also set the version in pkgorigins (#44318)

ba72387

(cherry picked from commit 21e5a26)

Make llvmunwind depend on llvm (#45380)

9e17fb6

(cherry picked from commit 6ea9034)

csl.mk: use libgcc_s 1.1 on aarch64-darwin (#45504)

b6e47d4

(cherry picked from commit 6f8860c)

Fix zero-length array concatenation validation (#45383)

d6bbed6

(cherry picked from commit 0a55a8e)

Fix segfault in Diagonal * OffsetMatrix (#45548)

a004142

* diagonal*offset matrix should throw (cherry picked from commit 172bddc)

bump Pkg version to latest 1.8

6f0bfc2

[Profile] threads here is wrong to use nthreads (#45547)

087ba27

Since the `data` argument possibly does not come from the current configuration, we should not use `nthreads` here either to filter out possibly significant data. (cherry picked from commit b46c14e)

rename is_concrete_eval_eligible utility query to is_foldable (#4…

43df1f4

…5615) `is_foldable` should be more aligned with `Base.@assume_effects`. This should be backported to 1.8 also.

Revert "codegen: explicitly handle Float16 intrinsics (#45249)" (#45627)

3a2eb39

This reverts commit eb82f18.

LebedevRI and others added 2 commits June 14, 2022 13:19

AMD Zen 3 CPU support (Fixes #45657) (#45663) (#45667)

8fd0b2a

I've omitted `invpcid` feature since it's clearly omitted for other CPU's. Fixes #45657 (cherry picked from commit 3f047f7)

update @assume_effects

8b2e406

vchuravy and others added 20 commits July 4, 2022 17:02

Update LLVM to 13.0.1+1

38b836a

fixup! Update LLVM to 13.0.1+1

4acdabe

fixup! fixup! Update LLVM to 13.0.1+1

853dff9

Improve inference in typejoin (#44390)

67f365c

This fixes hundreds of invalidations from Unitful. Co-authored by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>

[1.8] Update LLVM to 13.0.2-2 (#45917)

f83a9b3

Report any recompilation in time macro (#45015)

b97d34a

`@time` now shows if any of the compilation time was spent recompiling invalidated methods. The new percentage is % of the compilation time, not the total execution time. (cherry picked from commit 7074f04)

Add compilation & recompilation time to time_imports macro (#45064)

ad61d03

(cherry picked from commit 9320fba)

loading: prevent module replacement during precompile

0646ce7

This is theoretically okay, but unlikely to be intended ever. (cherry picked from commit d81724a)

loading: add missing deadlock causing #45704

89cb6df

Does not explicitly close issue #45704, as perhaps the deserialized module should still be valid after the replacement warning. (cherry picked from commit ad8893b)

loading: validate all cache files before loading any

73b37b2

Ensures we do not get easily wedged into bad states. (cherry picked from commit d0e28af)

loading: stop corrupting memory all over the place

0ce21a6

Regressions introduced by #45607 (cherry picked from commit 239a1f2)

Fix llvm powi intrinsic calls in fastmath.jl (#44580)

11cfa4e

(cherry picked from commit b49a1b4)

fix tuple_tfunc on Union containing Type{...} (#44725)

8fcc2dd

fix #44705 (cherry picked from commit 4115686)

inference: don't widen DataType/UninAll to Type within `tuple_t…

97c17e0

…func` (#44896) Follows up #44725. (cherry picked from commit 0deb326)

Pass along backlog keyword argument in Sockets.listen (#45737)

fbae62d

(cherry picked from commit 4f1c68e)

Use https for downloading of unicode data from unicode.org (#45750)

0559fa6

(cherry picked from commit 9b83dd8)

Fix libblastrampoline full source build to install into the right loc…

929c48a

…ation (#45746) * Bump LBT to 5.1.1 * Use DESTDIR to install into * Update LBT checksums (cherry picked from commit 1d78265)

Document file descriptors in run (#45710)

14be137

(cherry picked from commit 1f99ee9)

fix obvious_subtype bug with egal objects (#45771)

5894899

When egal objects contain identical typevars with different environments, the resulting subtyping might not be so obvious. Fix #45703 (cherry picked from commit 8ccf2d6)

Remove duplicate definition of jl_gc_safepoint (#45120)

2b6c746

This prevents a compiler warning on some systems (cherry picked from commit 05eb153)

KristofferC force-pushed the backports-release-1.8 branch from a87550d to 2b6c746 Compare July 4, 2022 15:15

KristofferC merged commit 381eac3 into release-1.8 Jul 6, 2022

KristofferC deleted the backports-release-1.8 branch July 6, 2022 11:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backports for 1.8-rc2/1.8.0 #45491

Backports for 1.8-rc2/1.8.0 #45491

KristofferC commented May 28, 2022 •

edited

Loading

ufechner7 commented Jun 2, 2022

KristofferC commented Jun 2, 2022 •

edited

Loading

KristofferC commented Jun 2, 2022

ufechner7 commented Jun 2, 2022 •

edited

Loading

KristofferC commented Jun 8, 2022

KristofferC commented Jun 8, 2022

nanosoldier commented Jun 8, 2022

nanosoldier commented Jun 8, 2022

vtjnash commented Jun 9, 2022

KristofferC commented Jun 13, 2022

nanosoldier commented Jun 13, 2022

KristofferC commented Jun 22, 2022

nanosoldier commented Jun 23, 2022

KristofferC commented Jul 4, 2022

KristofferC commented Jul 4, 2022

nanosoldier commented Jul 5, 2022

nanosoldier commented Jul 5, 2022

Backports for 1.8-rc2/1.8.0 #45491

Backports for 1.8-rc2/1.8.0 #45491

Conversation

KristofferC commented May 28, 2022 • edited Loading

ufechner7 commented Jun 2, 2022

KristofferC commented Jun 2, 2022 • edited Loading

KristofferC commented Jun 2, 2022

ufechner7 commented Jun 2, 2022 • edited Loading

KristofferC commented Jun 8, 2022

KristofferC commented Jun 8, 2022

nanosoldier commented Jun 8, 2022

nanosoldier commented Jun 8, 2022

vtjnash commented Jun 9, 2022

KristofferC commented Jun 13, 2022

nanosoldier commented Jun 13, 2022

KristofferC commented Jun 22, 2022

nanosoldier commented Jun 23, 2022

KristofferC commented Jul 4, 2022

KristofferC commented Jul 4, 2022

nanosoldier commented Jul 5, 2022

nanosoldier commented Jul 5, 2022

KristofferC commented May 28, 2022 •

edited

Loading

KristofferC commented Jun 2, 2022 •

edited

Loading

ufechner7 commented Jun 2, 2022 •

edited

Loading