Complete size checks in BLAS.[sy/he]mm!
#45605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
added
backport 1.6
|
Do the string operations add significant overhead if they aren't lazy? Otherwise, would be good to have this backported to v1.6 |
|
I just applied "pattern matching", but I could try to branch off from |
N5N3
reviewed
Jun 8, 2022
|
This still needs adjustments of the error messages and tests for the case |
ViralBShah
approved these changes
Jun 15, 2022
This was referenced Jul 5, 2022
|
Is this ready to go @dkarrasch? |
Yes, the only remaining question is how to help with the backport, since v1.6 doesn't have lazy strings. |
KristofferC
pushed a commit
that referenced
this pull request
Jul 7, 2022
(cherry picked from commit da13d78)
KristofferC
pushed a commit
that referenced
this pull request
Jul 8, 2022
(cherry picked from commit da13d78)
78 tasks
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit da13d78)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit da13d78)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit da13d78)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit da13d78)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit da13d78)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit da13d78)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit da13d78)
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit da13d78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/LinearAlgebra.jl#928. This should be backported to v1.6.x, but I'm not sure if that has the lazy string generation.