Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[win] Backport win MSYS2 build pr #46987

Closed
wants to merge 3 commits into from
Closed

[win] Backport win MSYS2 build pr #46987

wants to merge 3 commits into from

Commits on Sep 30, 2022

  1. Build/win: Build with MSYS2 (JuliaLang#46140) 

    * Makefile: MSYS2: close path conversion for `DEP_LIBS`

Automatic path conversion will replace `:` with `;`

* Makefile: MSYS2: use `cygpath` for path convert

ref: https://www.msys2.org/docs/filesystem-paths/#manual-unix-windows-path-conversion

* devdoc/win/msys2: add build steps

* devdoc/win/msys2: Add x86/x64 build notes

* devdoc/win/msys2: apply sugestions

Co-Authored-By: Elliot Saba <staticfloat@gmail.com>

* Instead of `CC_WITH_ENV`, scope environment variables to targets

* Fix whitespace

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
    @inkydragon @staticfloat
    inkydragon and staticfloat committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    170a1f6 View commit details
    Browse the repository at this point in the history

  2. Disable MSYS2's path munging for stringreplace (JuliaLang#46803) 

    This was causing our rewriting of the loader's RPATH emulation to fail
after running `make install`, as MSYS2 was rewriting our list that looks
like:

```
../bin/libgcc_s_seh-1.dll:../bin/libopenlibm.dll:@../bin/libjulia-internal.dll:@../bin/libjulia-codegen.dll:
```

Into one that looked like:
```
..\bin\libgcc_s_seh-1.dll;..\bin\libopenlibm.dll;@..\bin\libjulia-internal.dll;@..\bin\libjulia-codegen.dll;
```

By exporting `MSYS2_ARG_CONV_EXCL='*'` for all `stringreplace`
invocations, we dodge this issue, as documented by MSYS2 [0].

[0] https://www.msys2.org/wiki/Porting/#filesystem-namespaces
    @staticfloat @inkydragon
    staticfloat authored and inkydragon committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    385119f View commit details
    Browse the repository at this point in the history

  3. [win] Disable MSYS2 path munging when calling is.exe (JuliaLang#46867) 

    Tragically, I believe MSYS2 is messing with options such as
`/VERYSILENT` turning them instead into `C:\msys2\VERYSILENT` or
similar.
    @staticfloat @inkydragon
    staticfloat authored and inkydragon committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    ce62633 View commit details
    Browse the repository at this point in the history