Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CompilerSupportLibraries_jll] Update to new build #47444

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Nov 4, 2022

This fixes the dependency of libgcc_s.1.dylib (which is a light compatibility shim) on x86_64-apple-darwin-libgfortran5, to make the library properly loadable.

@KristofferC can you verify you can build julia on this branch on a fresh clone?

This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility
shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly
loadable.
@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs system:mac Affects only macOS labels Nov 4, 2022
@KristofferC
Copy link
Member

Yes, seems to work fine now. 👍

@giordano giordano added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 labels Nov 4, 2022
@giordano giordano merged commit 6321e47 into JuliaLang:master Nov 4, 2022
@giordano giordano deleted the mg/csl-libgcc-s branch November 4, 2022 09:37
@KristofferC KristofferC mentioned this pull request Nov 8, 2022
26 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Dec 14, 2022
@KristofferC
Copy link
Member

Backported in #47544

KristofferC pushed a commit that referenced this pull request Dec 21, 2022
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility
shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly
loadable.

(cherry picked from commit 6321e47)
@KristofferC
Copy link
Member

This breaks Float16 when backported to 1.6:

julia> Float16(Inf)
Float16(0.0)

for example.

@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 21, 2022
@giordano
Copy link
Contributor Author

That requires #45649 (see #45582 (comment)), was it backported already?

KristofferC pushed a commit that referenced this pull request Dec 21, 2022
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility
shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly
loadable.

(cherry picked from commit 6321e47)
@KristofferC
Copy link
Member

Seems to work with that backported.

@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label Dec 21, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility
shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly
loadable.

(cherry picked from commit 6321e47)
staticfloat pushed a commit that referenced this pull request Dec 24, 2022
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility
shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly
loadable.

(cherry picked from commit 6321e47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6 Change should be backported to release-1.6 building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants