-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CompilerSupportLibraries_jll] Update to new build #47444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly loadable.
giordano
added
building
Build system, or building Julia or its dependencies
external dependencies
Involves LLVM, OpenBLAS, or other linked libraries
JLLs
system:mac
Affects only macOS
labels
Nov 4, 2022
Yes, seems to work fine now. 👍 |
giordano
added
backport 1.6
Change should be backported to release-1.6
backport 1.8
Change should be backported to release-1.8
labels
Nov 4, 2022
26 tasks
Backported in #47544 |
78 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly loadable. (cherry picked from commit 6321e47)
This breaks Float16 when backported to 1.6:
for example. |
That requires #45649 (see #45582 (comment)), was it backported already? |
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly loadable. (cherry picked from commit 6321e47)
Seems to work with that backported. |
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly loadable. (cherry picked from commit 6321e47)
staticfloat
pushed a commit
that referenced
this pull request
Dec 24, 2022
This fixes the dependency of `libgcc_s.1.dylib` (which is a light compatibility shim) on `x86_64-apple-darwin-libgfortran5`, to make the library properly loadable. (cherry picked from commit 6321e47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.6
Change should be backported to release-1.6
building
Build system, or building Julia or its dependencies
external dependencies
Involves LLVM, OpenBLAS, or other linked libraries
JLLs
system:mac
Affects only macOS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the dependency of
libgcc_s.1.dylib
(which is a light compatibility shim) onx86_64-apple-darwin-libgfortran5
, to make the library properly loadable.@KristofferC can you verify you can build julia on this branch on a fresh clone?