Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CompilerSupportLibraries_jll] Upgrade to libraries from GCC 12 #47544

Merged
merged 6 commits into from
Nov 22, 2022
Merged

[CompilerSupportLibraries_jll] Upgrade to libraries from GCC 12 #47544

merged 6 commits into from
Nov 22, 2022

Conversation

tylerjthomas9
Copy link

@tylerjthomas9 tylerjthomas9 commented Nov 11, 2022 •
edited
Loading

I may be way off with this assessment, but the upgrade to libraries from GCC 12 seems like it should be plug-and-play with Julia 1.8. I added the final changes from #45582 and the CompilerSupportLibraries version bump from #47444.

awfeequdng and others added 5 commits November 8, 2022 08:14
@awfeequdng @KristofferC
move src and dst to next buffer position (#47229)
a24ca0b 
Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com>
(cherry picked from commit 9e1dac0)
@nrontsis @KristofferC
CircleCI caching: allow ftime to be ceil(ftime_req) in Base.stale_cac…
cf750d9 
…hefile (#47433)

* CircleCI caching: allow ftime to be ceil(ftime_req) in Base.stale_cachefile

It appears that [caching functionalities](https://circleci.com/docs/caching/) provided by CircleCi, a leading CI/CD provider, can truncate timestamps to full seconds, resulting in re-compilations as below:
```
Rejecting stale cache file /root/.julia/compiled/v1.8/ComponentArrays/cYHSD_3rQji.ji (mtime 1.6673960929277816e9) because file /root/.julia/packages/ComponentArrays/YyD7i/src/ComponentArrays.jl
```

This PR relaxes the `is_stale` check to be robust against rounding-to-second timestamp mutations.

I can provide a minimal CircleCI configuration file to reproduce if this is helpful.

(cherry picked from commit bf92e83)
@DilumAluthge @KristofferC
Delete .github/workflows/rerun_failed.yml (#47460)
67ffc74 
(cherry picked from commit ebc97ba)
@apaz-cli @KristofferC
Removed attributes from arguments to gc_preserve_begin (#47482)
9861bf1 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes #47245

(cherry picked from commit bc39fd1)
@tylerjthomas9
Upgrade to libraries from GCC 12
9c30685
@DilumAluthge DilumAluthge requested a review from a team as a code owner November 15, 2022 17:38
@brenhinkeller brenhinkeller added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Nov 16, 2022
@giordano giordano added building Build system, or building Julia or its dependencies JLLs labels Nov 21, 2022
@giordano
Copy link
Contributor

The only failed test is LinearAlgebra/special on i686 (both Linux and Windows), but @DilumAluthge said on Slack that this is a known failure on this branch on these platforms, so I'm going ahead and merging this. Thanks @tylerjthomas9 for this PR!

@giordano giordano merged commit c8b72e2 into JuliaLang:backports-release-1.8 Nov 22, 2022
@KristofferC KristofferC mentioned this pull request Dec 14, 2022
Merged
@antonio-rojas
Copy link
Contributor

This caused a regression in !macOS, see #47986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tylerjthomas9 @giordano @antonio-rojas @brenhinkeller @awfeequdng @nrontsis @DilumAluthge @apaz-cli