Revert "[CompilerSupportLibraries_jll] Add libssp for more platforms (#48027)" #48200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uliaLang#48027)" This reverts commit 0f2665f.
t-bltg
reviewed
Jan 10, 2023
| @@ -63,7 +59,7 @@ function __init__() | |||
| global libstdcxx_path = dlpath(libstdcxx_handle) | |||
| global libgomp_handle = dlopen(libgomp) | |||
| global libgomp_path = dlpath(libgomp_handle) | |||
| @static if libc(HostPlatform()) != "musl" | |||
| if Sys.iswindows() | |||
| global libssp_handle = dlopen(libssp) | |||
There was a problem hiding this comment.
Alternatively, one could maybe use something like:
@static if libc(HostPlatform()) != "musl"
global libssp_handle = dlopen(libssp; throw_error = false)
global libssp_path = libssp_handle === nothing ? nothing : dlpath(libssp_handle)
endin __init__, making the absence of libssp non-fatal.
EDIT: implemented in #48333.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wouldn't know what else to do with this. Fixes #48177.