Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dlopening libssp non fatal #48333

Merged
merged 3 commits into from
Jan 22, 2023
Merged

make dlopening libssp non fatal #48333

merged 3 commits into from
Jan 22, 2023

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Jan 18, 2023

Alternative to #48200, to be discussed.

Fix #48177.

cc @giordano, @staticfloat

@giordano
Copy link
Contributor

I'm not a fan of this solution. Libraries should either always exist or not, otherwise they can't be relied on.

@staticfloat
Copy link
Member

I think that:

  • We need to load libssp to satisfy some JLLs that are already out in the wild.
  • We don't care about having a handle to libssp since we never use it directly.
  • libssp is not available on some platforms.

If those are all true, I think I would use dlopen(libssp; throw_error = false) and then just throw away the return value. Don't save a libssp_handle and just use this to load the library into the dynamic linker's tables and call it a day. That way we dodge any problem of a handle being defined on some platforms and not others.

@vtjnash vtjnash merged commit 2949879 into JuliaLang:master Jan 22, 2023
@vtjnash
Copy link
Member

vtjnash commented Jan 22, 2023

First priority here is to fix the regression, often above all other niceties

@vtjnash vtjnash added backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 labels Jan 22, 2023
@t-bltg t-bltg deleted the libssp branch January 22, 2023 07:01
KristofferC pushed a commit that referenced this pull request Jan 23, 2023
(cherry picked from commit 2949879)
@KristofferC KristofferC mentioned this pull request Feb 1, 2023
35 tasks
KristofferC pushed a commit that referenced this pull request Feb 6, 2023
(cherry picked from commit 2949879)
@KristofferC KristofferC mentioned this pull request Feb 6, 2023
16 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8 Change should be backported to release-1.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

julia 1.8.5 - could not load library "libssp.so.0" (linux)
5 participants