Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtype: fix obviously_disjoint for Union Types #49177

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Mar 29, 2023

Found in #48935 (comment).

It looks hard to reproduce this error under normal build as obviously_subtype handle Unions correctly.

@N5N3 N5N3 added types and dispatch Types, subtyping and method dispatch bugfix This change fixes an existing bug labels Mar 29, 2023
@N5N3
Copy link
Member Author

N5N3 commented Mar 29, 2023

@nanosoldier runtests(["TKTDsimulations", "MITgcmTools", "FITSIO", "MLJJLBoost", "Catlab", "QuerySQLite", "EBayes", "OpenTelemetryAPI", "MultiDocumenter", "Elfel", "LocalApproximationValueIteration", "ShellModel", "Arrow", "RelativisticDynamics", "BloqadeODE", "MakieThemes", "UncertainData", "GraphsMatching", "ConstrainedDynamicsVis", "RayTracing", "BioMart", "SymbolicRegression", "DTALib", "RvSpectMLBase", "BufferedStreams", "ReactiveDynamics", "Infernal", "QuantumCumulants", "FMIImport", "GCPDecompositions", "AppliGeneralLedger", "RRTMGP", "FilteredGroupbyMacro", "SubSIt", "HorseML", "EvaluationCF", "Trixi2Vtk", "VoronoiFVM", "NaiveNASflux", "NonconvexMultistart", "MzPlots", "DECAES", "SeaPearlZoo", "AtomGraphs", "AlgebraicAgents", "Rfam", "BioGraph", "BM3DDenoise", "Expect", "OteraEngine", "ContinuousTimePolicyGradients", "ClimaAtmos"], vs = ":release-1.9", configuration = (buildflags = ["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],), vs_configuration = (buildflags = ["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))

@N5N3 N5N3 added the backport 1.9 Change should be backported to release-1.9 label Mar 29, 2023
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Mar 29, 2023
@vtjnash

This comment was marked as outdated.

@nanosoldier
Copy link
Collaborator

Your job failed. Consult the server logs for more details (cc @maleadt).

@KristofferC KristofferC mentioned this pull request Mar 30, 2023
52 tasks
@KristofferC
Copy link
Member

I'll merge this and run PkgEval again on the backport branch.

@KristofferC KristofferC merged commit 2092000 into JuliaLang:master Mar 30, 2023
KristofferC pushed a commit that referenced this pull request Mar 30, 2023
@maleadt
Copy link
Member

maleadt commented Mar 30, 2023

The same build failure again, resulting in an EAGAIN when building stdlibs. I'll try rebooting the PkgEval server once it finishes the current daily evaluation.

aviatesk pushed a commit that referenced this pull request Mar 30, 2023
@N5N3 N5N3 deleted the Subtype-fix branch March 30, 2023 09:24
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Apr 11, 2023
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants