Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore modname == NULL behavior for jl_load_dynamic_library #49611

Merged
merged 1 commit into from
May 3, 2023
Merged

Restore modname == NULL behavior for jl_load_dynamic_library #49611

merged 1 commit into from
May 3, 2023

Commits on May 3, 2023

  1. Restore modname == NULL behavior for jl_load_dynamic_library 

    Within the Julia runtime, this usage has been superseded by the new
`jl_find_library_by_addr`, but this is still used downstream.

In particular, CBinding.jl ends up using this branch to get a handle
to libjulia-internal (perhaps a bit accidentally, since the comments
in CBinding.jl suggest it intends to get a handle to the exe)

This restores the behavior to avoid downstream breakage.
    @topolarity
    topolarity committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9986018 View commit details
    Browse the repository at this point in the history