Restore modname == NULL behavior for jl_load_dynamic_library
#49611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the Julia runtime, this usage has been superseded by the new `jl_find_library_by_addr`, but this is still used downstream. In particular, CBinding.jl ends up using this branch to get a handle to libjulia-internal (perhaps a bit accidentally, since the comments in CBinding.jl suggest it intends to get a handle to the exe) This restores the behavior to avoid downstream breakage.
maleadt
approved these changes
May 3, 2023
vtjnash
approved these changes
May 3, 2023
|
c.f. 653fb16 #21299 (comment) |
|
Merging this before the next PkgEval run starts. |
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the Julia runtime, this usage has been superseded by the new
jl_find_library_by_addr, but this is still used downstream.In particular, CBinding.jl ends up using this branch to get a handle to libjulia-internal (perhaps a bit accidentally, since the comments in CBinding.jl suggest it intends to get a handle to the exe)
This restores the behavior to avoid downstream breakage.