Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for julia 1.9.1 #49680

Merged
merged 38 commits into from
May 28, 2023
Merged

Backports for julia 1.9.1 #49680

merged 38 commits into from
May 28, 2023

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented May 8, 2023 •
edited by maleadt
Loading

Backported PRs:

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

Azzaare and others added 8 commits May 8, 2023 09:14
@Azzaare
Update parallel.md (#49308)
177f6ef 
Removes the duplicate header `Synchronization`

(cherry picked from commit 7ddb4e5)
@NHDaly
Nospecialize close(c::Channel, excp::Exception) on excp. (#49508)
cd960d9 
* Nospecialize close(c::Channel, excp::Exception) on excp.

Fixes #49507.

Avoids dynamic dispatch when closing a Channel with an Exception, and
should avoid a call into the runtime for julia compilation when
attempting to report an exception.

* Add test for this case.

(cherry picked from commit a152d11)
@KristofferC
remove debug print from loading test (#49534)
c613d9c 
(cherry picked from commit bf7bd3f)
@KristofferC
add two more explicit precompile statements (#49537)
0ef50aa 
(cherry picked from commit 09a0f34)
@maleadt
Preserve LLVM function attributes during address space removal pass. (#…
fdff436 
…49551)

(cherry picked from commit 4289264)
@aravindh-krishnamoorthy
Ensure length(ipiv)==n before calling LAPACK.getrs! to avoid segfaults (
f7b39e7 
#49602)

(cherry picked from commit b66f63c)
@KristofferC
shield Base.require from invalidations when loading Symbolics.jl (#…
c9f59c9 
…49604)

(cherry picked from commit 5039d8a)
@vtjnash
fix some SCC cycle mistakes (#49654)
441a84e 
(cherry picked from commit 9bb0731)
@KristofferC KristofferC added the release Release management and versioning. label May 8, 2023
@KristofferC KristofferC force-pushed the backports-release-1.9 branch from 8cd408d to 6c2d506 Compare May 8, 2023 08:30
@ViralBShah ViralBShah mentioned this pull request May 8, 2023
Merged
@KristofferC
Copy link
Member Author

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your job failed. Consult the server logs for more details (cc @maleadt).

@maleadt
Copy link
Member

maleadt commented May 16, 2023

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your job failed. Consult the server logs for more details (cc @maleadt).

@maleadt
Copy link
Member

maleadt commented May 16, 2023

Forgot to restart the server after my bugfix... Let's try again:

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@KristofferC
Copy link
Member Author

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["Evolutionary", "Test", "Probably", "QuantumCumulants", "HarmonicBalance", "MPIMeasurements", "NNlib", "OptimizationMetaheuristics", "Comrade", "GADM", "FractalDimensions", "SmartML", "AlgebraicRL", "Dynesty", "ReactiveMP", "ModelingToolkit"], vs = ":release-1.9")

@Bo98
Copy link

Bo98 commented May 20, 2023

Can I request a backport of this one line: 1e5fdb2#diff-5367a24cd5303d6218f61148f2db355c3f3c682ec003630cf9730fa02b8d8429L1056-R1084? I believe this to be the cause of #49895, and the change should be compatible with the older MPFR version used in 1.9.

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@IanButterworth IanButterworth mentioned this pull request May 22, 2023
Merged
@KristofferC
Copy link
Member Author

@nanosoldier runtests(vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@KristofferC
Copy link
Member Author

@aviatesk, do you understand https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/d105b83_vs_8e63055/ControlSystems.primary.log?

Internal error: encountered unexpected error in runtime:
MethodError(f=Core.Compiler.widenconst, args=(_copyto_impl!(Array{Int64, 2}, Int64, Array{Int64, 2}, Int64, Int64) from _copyto_impl!(Array{T, N} where N where T, Integer, Array{T, N} where N where T, Integer, Integer),), world=0x00000000000014db)
jl_method_error_bare at /cache/build/default-amdci5-6/julialang/julia-release-1-dot-9/src/gf.c:2076
jl_method_error at /cache/build/default-amdci5-6/julialang/julia-release-1-dot-9/src/gf.c:2094
jl_lookup_generic_ at /cache/build/default-amdci5-6/julialang/julia-release-1-dot-9/src/gf.c:2921 [inlined]
ijl_apply_generic at /cache/build/default-amdci5-6/julialang/julia-release-1-dot-9/src/gf.c:2936
widen_all_consts! at ./compiler/typeinfer.jl:596
ir_to_codeinf! at ./compiler/optimize.jl:182 [inlined]
transform_result_for_cache at ./compiler/typeinfer.jl:373 [inlined]
cache_result! at ./compiler/typeinfer.jl:404
_typeinf at ./compiler/typeinfer.jl:293
typeinf at ./compiler/typeinfer.jl:216
typeinf_edge at ./compiler/typeinfer.jl:933
abstract_call_method at ./compiler/abstractinterpretation.jl:611
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:152
abstract_call_known at ./compiler/abstractinterpretation.jl:1949
abstract_call at ./compiler/abstractinterpretation.jl:2020
abstract_call at ./compiler/abstractinterpretation.jl:1999
abstract_eval_statement_expr at ./compiler/abstractinterpretation.jl:2183
abstract_eval_statement at ./compiler/abstractinterpretation.jl:2396
abstract_eval_basic_statement at ./compiler/abstractinterpretation.jl:2684
typeinf_local at ./compiler/abstractinterpretation.jl:2869

@aviatesk
Copy link
Member

I can look into it tomorrow.

@aviatesk
Copy link
Member

@aviatesk, do you understand https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/d105b83_vs_8e63055/ControlSystems.primary.log?

Hmm, I couldn't reproduce it on both mac and Linux. Let me run it again:
@nanosoldier runtests(["ControlSystems"], vs=":release-1.9")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected.
A full report can be found here.

@aviatesk
Copy link
Member

The error seems to have disappeared:)

staticfloat and others added 24 commits May 27, 2023 21:36
@staticfloat @KristofferC
Bump LBT to v5.8.0 (#49658)
a98b387 
Includes: JuliaLinearAlgebra/libblastrampoline@8131615
(cherry picked from commit 4e782bf)
@SamuelBadr @KristofferC
Allow showing of StepRangLen{T} with generic T (#49516)
be67a40 
(cherry picked from commit ee95843)
@pchintalapudi @KristofferC
Initialize hoisted object allocations (#49584)
f81bada 
(cherry picked from commit 5032a1a)
@vchuravy @KristofferC
Export offsets necessary for external codegen (#49548)
c3d84e4 
(cherry picked from commit faced27)
@KristofferC
minimal changes to avoid Artifacts to get invalidated by some common …
b15d8a9 
…definitions in ecosystem (#49603)

(cherry picked from commit 43c9202)
@maleadt @KristofferC
Ensure LLVM function attributes are preserved by always calling Clone…
9ce1976 
…FunctionInto.

(cherry picked from commit f77ad0a)
@maleadt @KristofferC
Don't explicitly remap the personality function.
1602dc1 
LLVM does this already.

(cherry picked from commit b815bb1)
@PallHaraldsson @KristofferC
Clarify Cxx.jl. Update calling-c-and-fortran-code.md (#49379)
16579c4 
* Update calling-c-and-fortran-code.md Drop mentioning Cxx.jl

(cherry picked from commit e998367)
@kdheepak @KristofferC
Add @eval using REPL to the atreplinit do block in REPL documenta…
7ab56f4 
…tion. (#49717)

(cherry picked from commit 24a5dc4)
@MasonProtter @KristofferC
add note about references in Out (#49729)
efa269e 
(cherry picked from commit e4633e0)
@KristofferC
Artifacts: pull out a recursive function from a closure to a stand al…
42d4b97 
…one function (#49755)

(cherry picked from commit 6733197)
@KristofferC
allow loading extensions when a trigger is loaded from below the pare…
d175b27 
…nt's load path (#49701)

also allow loading extensions of the active project

(cherry picked from commit d55314c)
@DilumAluthgeBot @KristofferC
🤖 [backports-release-1.9] Bump the Pkg stdlib from 3ca88658d to 7276c…
303ea52 
…7514 (#49877)
@kpamnany @KristofferC
Fix subtyping freeze in 1.9.0 (#49875)
1dd49c9 
* Disable slow path to handle Union explosion

* 3 tests are broken due to disabling slow path
@vtjnash @KristofferC
[Profile] fix overhead counts in format=:flat (#49824)
f07ed54 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732

(cherry picked from commit 45748b8)
@staticfloat @KristofferC
[cli] Ensure that probed libstdc++ path is NULL-terminated
ca5ee23 
It appears that we were assuming our path was initialized with zeros, but that is not a safe assumption.

(cherry picked from commit 7111597)
@aviatesk @KristofferC
improve inferrability of loading.jl
4ce8bf8 
(cherry picked from commit 7c24cc6)
@aviatesk @KristofferC
follow up #49812, fix the wrong type declaration (#49854)
c3458d0 
#49812 introduced a bug and broke the CI.
This commit fixes it up.

(cherry picked from commit 869c70e)
@NHDaly @KristofferC
Fix thread safety in atexit(f): Lock access to atexit_hooks (#49774)
23c0d24 
- atexit(f) mutates global shared state.
- atexit(f) can be called anytime by any thread.
- Accesses & mutations to global shared state must be locked if they can
  be accessed from multiple threads.

Add unit test for thread safety of adding many atexit functions in
parallel

(cherry picked from commit 9dd3090)
@staticfloat @KristofferC
Merge pull request #49842 from JuliaLang/sf/dont_eagerly_load_libgomp
9e94f66 
Don't depend on `CompilerSupportLibraries_jll` from `OpenBLAS_jll`

(cherry picked from commit 98b64b2)
@pchintalapudi @KristofferC
Fix MemorySSA bug, broken julia-licm test (#49900)
83263ee
@giordano @simonbyrne @KristofferC
[MPFR] Fix printing of BigFloat (#49909)
d40e71a 
Co-authored-by: Simon Byrne <simon.byrne@gmail.com>
@DilumAluthgeBot @DilumAluthge @KristofferC
🤖 [backports-release-1.9] Bump the Pkg stdlib from 7276c7514 to 3fa06…
4a46ccb 
…b9f9 (#49926)

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
@jakobnissen @KristofferC
Improve type stability of array_subpadding slightly (#48136)
295b503 
This should be slightly more efficient as the compiler now only tries to call
`iterate` on `t` and `s` once, and will not try to destructure the result if
the `iterate` call returns `nothing`.
This change reduce spurious JET warnings.
@KristofferC KristofferC force-pushed the backports-release-1.9 branch from 5412389 to 295b503 Compare May 27, 2023 19:37
@ranocha ranocha mentioned this pull request May 28, 2023
Merged
@KristofferC KristofferC merged commit a7348b7 into release-1.9 May 28, 2023
@KristofferC KristofferC deleted the backports-release-1.9 branch May 28, 2023 17:42
This was referenced Jun 1, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release Release management and versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.