-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation update for LinearAlgebra functions #52934
Documentation update for LinearAlgebra functions #52934
Conversation
Note that you'll also need to change julia/stdlib/LinearAlgebra/test/runtests.jl Lines 8 to 12 in ab9573f
@testset "Docstrings" begin
@test isempty(Docs.undocumented_names(LinearAlgebra))
end |
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! I have a few suggestions for consideration. Otherwise looks good to me.
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
I suggested a few more clarifications to the pivoting docs, above, which would be good to incorporate before merging. |
Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Is this something we can merge before the branch tomorrow, or will it miss the v1.11 window? |
We should be able to merge it, or just in case backport. |
Documentation update for LinearAlgebra functions, see #52725
Pivoting strategies
NoPivot
RowNonZero
ColumnNorm
RowMaximum
Matrix multiplication functions
copy_transpose!
copyto!
Note:
copyto!
is not mentioned in the original issue. However, it is felt thatcopy_transpose!
without the complementingcopyto!
will be confusing for a reader.LAPACKException
RankDeficientException
Reviews
Tests
make docs
.