Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for LinearAlgebra functions #52934

Merged
merged 19 commits into from
Feb 12, 2024

Conversation

aravindh-krishnamoorthy
Copy link
Contributor

@aravindh-krishnamoorthy aravindh-krishnamoorthy commented Jan 16, 2024

Documentation update for LinearAlgebra functions, see #52725

  • Pivoting strategies

    • NoPivot
    • RowNonZero
    • ColumnNorm
    • RowMaximum
  • Matrix multiplication functions

    • copy_transpose!
    • copyto!

Note: copyto! is not mentioned in the original issue. However, it is felt that copy_transpose! without the complementing copyto! will be confusing for a reader.

  • Exceptions
    • LAPACKException
    • RankDeficientException

Reviews

  • Self-review of content and language by the author.
  • Move PR out of draft state and trigger external reviewers.

Tests

  • Test make docs.
  • Check generated en HTML files.

@stevengj
Copy link
Member

Note that you'll also need to change

@testset "Docstrings" begin
undoc = Docs.undocumented_names(LinearAlgebra)
@test_broken isempty(undoc)
@test undoc == [:ColumnNorm, :LAPACKException, :NoPivot, :RankDeficientException, :RowMaximum, :RowNonZero, :copy_transpose!]
end
to

@testset "Docstrings" begin
    @test isempty(Docs.undocumented_names(LinearAlgebra))
end

@stevengj stevengj added docs This change adds or pertains to documentation linear algebra Linear algebra labels Jan 19, 2024
@aravindh-krishnamoorthy aravindh-krishnamoorthy marked this pull request as ready for review February 3, 2024 22:40
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! I have a few suggestions for consideration. Otherwise looks good to me.

stdlib/LinearAlgebra/src/LinearAlgebra.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/src/LinearAlgebra.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/src/matmul.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/src/LinearAlgebra.jl Outdated Show resolved Hide resolved
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label Feb 7, 2024
@stevengj stevengj removed the merge me PR is reviewed. Merge when all tests are passing label Feb 7, 2024
@stevengj
Copy link
Member

stevengj commented Feb 7, 2024

I suggested a few more clarifications to the pivoting docs, above, which would be good to incorporate before merging.

Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
@vtjnash
Copy link
Member

vtjnash commented Feb 12, 2024

Is this something we can merge before the branch tomorrow, or will it miss the v1.11 window?

@dkarrasch
Copy link
Member

We should be able to merge it, or just in case backport.

@dkarrasch dkarrasch added the merge me PR is reviewed. Merge when all tests are passing label Feb 12, 2024
@vtjnash vtjnash merged commit f8d5947 into JuliaLang:master Feb 12, 2024
6 of 8 checks passed
@aravindh-krishnamoorthy aravindh-krishnamoorthy deleted the la_addnl_docs branch February 12, 2024 23:00
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants