Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for LinearAlgebra functions #52934

Merged
merged 19 commits into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fb9bdd9
Addnl LA Documentation: Dummy commit with TODOs to get a PR started.
aravindh-krishnamoorthy Jan 16, 2024
aace7ac
LinearAlgebra: Remove exceptions for exported but undocumented functi…
aravindh-krishnamoorthy Jan 19, 2024
8c8edbb
Update LinearAlgebra test to ensure no undocumented exported symbols
aravindh-krishnamoorthy Jan 20, 2024
7bee3ae
Update stdlib/LinearAlgebra/test/runtests.jl
aravindh-krishnamoorthy Jan 20, 2024
0f89207
Update stdlib/LinearAlgebra/test/runtests.jl
aravindh-krishnamoorthy Jan 20, 2024
9267ce2
Merge branch 'master' into la_addnl_docs
aravindh-krishnamoorthy Jan 24, 2024
4b4587c
DocStrings for copy_transpose!
aravindh-krishnamoorthy Jan 24, 2024
c0acaad
DocStrings for RankDeficientException and LAPACKException.
aravindh-krishnamoorthy Jan 26, 2024
f27751d
Initial text on pivoting
aravindh-krishnamoorthy Jan 27, 2024
de24482
Added DocStrings to copyto!
aravindh-krishnamoorthy Jan 28, 2024
6f3338e
Documentation for pivoting and pivoting strategies.
aravindh-krishnamoorthy Jan 29, 2024
61bf648
Incorporate changes from self review.
aravindh-krishnamoorthy Feb 3, 2024
d47f20e
index.md: Remove trailing whitespace.
aravindh-krishnamoorthy Feb 3, 2024
72a188a
Apply suggestions from code review by @dkarrasch
aravindh-krishnamoorthy Feb 7, 2024
e3985dd
Apply suggestions from code review by @stevengj and @dkarrasch
aravindh-krishnamoorthy Feb 7, 2024
296ecd5
Update stdlib/LinearAlgebra/src/matmul.jl
aravindh-krishnamoorthy Feb 7, 2024
a653963
Remove non-breaking space
aravindh-krishnamoorthy Feb 7, 2024
3cb092e
fix adjoint case in copyto!
dkarrasch Feb 11, 2024
a7fd509
fix typo
dkarrasch Feb 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stdlib/LinearAlgebra/src/LinearAlgebra.jl
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ abstract type Algorithm end
struct DivideAndConquer <: Algorithm end
struct QRIteration <: Algorithm end

# TODO: Insert docstrings for pivoting strategies here.

abstract type PivotingStrategy end
struct NoPivot <: PivotingStrategy end
struct RowNonZero <: PivotingStrategy end
Expand Down
4 changes: 4 additions & 0 deletions stdlib/LinearAlgebra/src/exceptions.jl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ export LAPACKException,
RankDeficientException,
ZeroPivotException

# TODO: Insert docstring for LAPACKException here.

struct LAPACKException <: Exception
info::BlasInt
end
Expand Down Expand Up @@ -41,6 +43,8 @@ function Base.showerror(io::IO, ex::PosDefException)
print(io, "; Factorization failed.")
end

# TODO: Insert docstring for RankDeficientException here.

struct RankDeficientException <: Exception
info::BlasInt
end
Expand Down
2 changes: 2 additions & 0 deletions stdlib/LinearAlgebra/src/matmul.jl
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,8 @@ function copyto!(B::AbstractVecOrMat, ir_dest::AbstractUnitRange{Int}, jr_dest::
B
end

# TODO: Insert docstring for copy_transpose! here.

function copy_transpose!(B::AbstractMatrix, ir_dest::AbstractUnitRange{Int}, jr_dest::AbstractUnitRange{Int}, tM::AbstractChar, M::AbstractVecOrMat, ir_src::AbstractUnitRange{Int}, jr_src::AbstractUnitRange{Int})
if tM == 'N'
LinearAlgebra.copy_transpose!(B, ir_dest, jr_dest, M, ir_src, jr_src)
Expand Down
2 changes: 0 additions & 2 deletions stdlib/LinearAlgebra/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,4 @@ end

@testset "Docstrings" begin
undoc = Docs.undocumented_names(LinearAlgebra)
aravindh-krishnamoorthy marked this conversation as resolved.
Show resolved Hide resolved
@test_broken isempty(undoc)
@test undoc == [:ColumnNorm, :LAPACKException, :NoPivot, :RankDeficientException, :RowMaximum, :RowNonZero, :copy_transpose!]
end