Track "permanently defined" status for bindings #54728
Open
+93
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `is_opaque_closure`
This change regains some inference power that we lost with JuliaLang#53750. It adds an `isdefined` bit to all bindings to track whether they were defined when their module was open. If so, we can be sure that they will be defined forever.
This code had not considered "mutation tearing", so the emitted operations could be incorrect if any mutations were dropped.
|
Needs tests, but also will stop working after #54654. |
Only the |
vtjnash
reviewed
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change regains some inference power that we lost with #53750.
It adds an
isdefinedbit to all bindings to track whether they were defined when their module was open - if so, we can be sure that they will be defined forever.This does not implement support for the atomic global ops, since those are far less common - this is a "best effort" bit, so it's only an inference/optimization impact if we fail to set it (in any case, no worse than the status quo today)