Backport Subtype: some performance tuning. (#56007) #56117
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation of this PR is to fix #55807.
dc689fe tries to remove the slow
may_contain_union_decision
check by re-organizing the code path. Now the fast path has been removed and most of its optimization has been integrated into the preserved slow path.Since the slow path stores all inner ∃ decisions on the outer most R stack, there might be overflow risk.
aee69a4 should fix that concern.
The reported MWE now becomes
Local bench also shows that 72855cd slightly accelerates
OmniPackage.jl
's loading