Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: fix several more specialization mistake introduced by #40985 #56547

Merged
merged 1 commit into from
Nov 14, 2024
Merged

compiler: fix several more specialization mistake introduced by #40985 #56547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Compiler/src/abstractinterpretation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2199,9 +2199,13 @@ function abstract_invoke(interp::AbstractInterpreter, arginfo::ArgInfo, si::Stmt
env = tienv[2]::SimpleVector
mresult = abstract_call_method(interp, method, ti, env, false, si, sv)::Future
match = MethodMatch(ti, env, method, argtype <: method.sig)
ft_box = Core.Box(ft)
ft′_box = Core.Box(ft′)
return Future{CallMeta}(mresult, interp, sv) do result, interp, sv
(; rt, exct, effects, edge, volatile_inf_result) = result
res = nothing
local argtypes = arginfo.argtypes
local ft = ft_box.contents
Comment on lines +2206 to +2207
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These actually might have been unnecessary, since argtypes should be a Vector{Any} and ft appears unused

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#56560

local ft′ = ft′_box.contents
sig = match.spec_types
argtypes′ = invoke_rewrite(argtypes)
fargs = arginfo.fargs
Expand Down