source build: fix openssl race in installing libssh2 #59141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
the
building
|
Actually seems like a common pattern so I update the remainder? |
vtjnash
reviewed
Jul 29, 2025
|
ok. The issue this tried to fix was |
This comment was marked as outdated.
This comment was marked as outdated.
|
Actually, I think this may always be failing on that particular bot (we just don't run it very often). It's possible we don't see it locally because the build picks up system openssl. |
|
Yeah: |
Keno
added a commit
that referenced
this pull request
Jul 31, 2025
Addresses the same CI failure that #59141 was intended to address. The issue here is twofold. First, in a source build, we failed to install openssl header files. Second, even if we had done this, libssh needs to be explicitly told where to find openssl, otherwise it might prefer systme files.
Keno
added a commit
that referenced
this pull request
Jul 31, 2025
Addresses the same CI failure that #59141 was intended to address. The issue here is twofold. First, in a source build, we failed to install openssl header files. Second, even if we had done this, libssh needs to be explicitly told where to find openssl, otherwise it might prefer systme files.
Keno
added a commit
that referenced
this pull request
Jul 31, 2025
Addresses the same CI failure that #59141 was intended to address. The issue here is twofold. First, in a source build, we failed to install openssl header files. Second, even if we had done this, libssh needs to be explicitly told where to find openssl, otherwise it might prefer systme files.
KristofferC
pushed a commit
that referenced
this pull request
Sep 17, 2025
Addresses the same CI failure that #59141 was intended to address. The issue here is twofold. First, in a source build, we failed to install openssl header files. Second, even if we had done this, libssh needs to be explicitly told where to find openssl, otherwise it might prefer systme files. (cherry picked from commit 5ddd721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change libssh2 to depend on
install-opensslinstead of just the manifest file to ensure OpenSSL is fully installed before libssh2 configuration.Fixes build failures where libssh2 CMake configuration runs before OpenSSL installation is complete, causing "Could NOT find OpenSSL" errors.
Claude suggested this based on https://buildkite.com/julialang/julia-buildkite-scheduled/builds/1333#01985642-15fe-4526-ac73-1cbbd40d85b4