build: Fix libssh2 source build #59164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the same CI failure that #59141 was intended to address. The issue here is twofold. First, in a source build, we failed to install openssl header files. Second, even if we had done this, libssh needs to be explicitly told where to find openssl, otherwise it might prefer systme files.
vtjnash
reviewed
Jul 31, 2025
There was a problem hiding this comment.
This seems somewhat confusingly documented, I think you have to edit the cmake file itself to enable the policy that allows it to pick up this flag, otherwise you should have gotten it already from CMAKE_PREFIX_PATH ahead of the system path https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure
|
OPENSSL_ROOT_DIR prevents it from picking up the system path. I don't know if it would have picked up the local openssl first with the build system fix automatically, but with OPENSSL_ROOT_DIR, it gives an appropriate error if it doesn't detect it where we expect. |
|
(Note that OpenSSL has a custom CMake dependency provider, so the linked documentation doesn't apply except in spirit) |
28 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 17, 2025
Addresses the same CI failure that #59141 was intended to address. The issue here is twofold. First, in a source build, we failed to install openssl header files. Second, even if we had done this, libssh needs to be explicitly told where to find openssl, otherwise it might prefer systme files. (cherry picked from commit 5ddd721)
This was referenced Sep 17, 2025
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the same CI failure that #59141 was intended to address. The issue here is twofold. First, in a source build, we failed to install openssl header files. Second, even if we had done this, libssh needs to be explicitly told where to find openssl, otherwise it might prefer systme files.