Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Uint => UInt (closes #8905) #8907

Merged
merged 1 commit into from
Nov 6, 2014
Merged

rename Uint => UInt (closes #8905) #8907

merged 1 commit into from
Nov 6, 2014

Conversation

StefanKarpinski
Copy link
Member

No description provided.

@StefanKarpinski
Copy link
Member Author

This makes concerns about whitespace fixes making merges hard seem completely and utterly silly.

@jakebolewski
Copy link
Member

Can we have that too? I'll submit a PR if we are being greedy today :-)

@StefanKarpinski
Copy link
Member Author

Yeah, of course. Not point not doing it now.

@jakebolewski
Copy link
Member

Ok. After this is merged.

@ivarne
Copy link
Member

ivarne commented Nov 5, 2014

I have a half finished git command to check for whitespace introduced in a PR. This way you would avoid builds from breaking when you you actually didn't introduce any errors.

git diff --check HEAD^1 HEAD^2 -- '*.jl' '*.cpp' '*.scm' '*.h' '*.c'

I'll test it with some different conditions on Travis tomorrow.

StefanKarpinski added a commit that referenced this pull request Nov 6, 2014
@StefanKarpinski StefanKarpinski merged commit cd450f6 into master Nov 6, 2014
ivarne added a commit to JuliaLang/Compat.jl that referenced this pull request Nov 6, 2014
@jiahao jiahao deleted the sk/UInt branch January 18, 2015 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants