-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt / Bump to ManifoldsBase 1.0 #437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kellertuer
commented
Feb 7, 2025
•
edited
Loading
edited
- Requires Adapt to ManifoldsBase 1.0 Manifolds.jl#781 to be merged and registered
- Requires Adapt / Bump to ManifoldsBase 1.0 ManoptExamples.jl#25 (for the tests and tutorials) to be merged and registered
kellertuer
added
the
Ready-for-Review
A label for pull requests that are feature-ready
label
Feb 7, 2025
mateuszbaran
approved these changes
Feb 7, 2025
Thanks :) Locally it already works, but it still does need the Manifolds-PR to be finished (will work on the code cov there later) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 99.88% 99.89% +0.01%
==========================================
Files 78 78
Lines 8384 8384
==========================================
+ Hits 8374 8375 +1
+ Misses 10 9 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.