Adapt / Bump to ManifoldsBase 1.0 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kellertuer
commented
Feb 7, 2025
•
kellertuer
commented
- requires Adapt to ManifoldsBase 1.0 Manifolds.jl#781 to be merged and registered
# Conflicts: # Project.toml # src/objectives/TotalVariation.jl
kellertuer
added
the
Ready-for-Review
2 tasks
|
LGTM, though I think the CI scripts should be updates to what the are in other repositories (testing on Julia 1, lts and pre) |
|
Good point, Will do that. This has to be released before I can do the Manopt-bump anyways, since Manopt uses some of the examples here to test. I am still not sure this is a good idea overall, so I might improve the ManoptTestSuite instead in the future instead. But sure, moving to a unified CI setup is a good idea. |
|
The tests here fail since we have the same circular dependency problem here. I will merge and register this, and will in the long run make Manopt independent of the example. |
|
Locally the tests run fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.