Remove arrays of scaling factors #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 93.57% 93.87% +0.30%
==========================================
Files 5 5
Lines 420 441 +21
==========================================
+ Hits 393 414 +21
Misses 27 27
☔ View full report in Codecov by Sentry. |
|
What do you think of adding tests of view inputs? E.g. see #117 (made a PR to this branch rather than a code suggestion since I cannot code suggest on unchanged files). |
stevengj
reviewed
Aug 10, 2023
gaurav-arya
approved these changes
Aug 10, 2023
|
Bump on merge? |
|
Can we get a release, mainly in order to include this PR and fix Zygote tests? (FluxML/Zygote.jl#1452) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #114 that avoids the computation of the array of scaling factors completely.
Tested locally with regular arrays and static arrays. Using
broadcastinstead ofmap(potentially includingdetc. as broadcasted arguments) would returnSizedArrays instead ofStaticArrays forSArrayinputs, hence I went withmapinstead.Has to be tested with Zygote and CUDA as well (for the latter it might be useful to set up GPU tests with buildkite and for the former downstream tests with Zygote, limited to FFTs, would be useful).
Edit: Tests of Zygote#master pass locally with this PR.