Test view inputs in interface tests #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dw/scale #117 +/- ##
=========================================
Coverage 93.84% 93.84%
=========================================
Files 5 5
Lines 439 439
=========================================
Hits 412 412
Misses 27 27
☔ View full report in Codecov by Sentry. |
|
Seems good and useful to me 👍 |
stevengj
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Remove arrays of scaling factors * Fix typo * Test view inputs in interface tests (#117) --------- Co-authored-by: Gaurav Arya <gauravarya272@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible test to add to #116
Note that this PR is to #116's branch (i.e. basically a code suggestion, but needed to do it this way since the test file was previously unchanged)