Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DoesNotExist with NoTangent #327

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

devmotion
Copy link
Member

Tests pass successfully locally with this PR.

@devmotion
Copy link
Member Author

@oxinabox should one update the lower bounds of ChainRulesCore and/or ChainRulesTestUtils? I lost a bit track of when the different deprecations were introduced and removed.

@oxinabox
Copy link
Contributor

oxinabox commented Jun 2, 2021

Oops I missed this in #319

Why didn't CI fail there?

should one update the lower bounds of ChainRulesCore and/or ChainRulesTestUtils?

No, I updated them in #319.
At least the ones for ChainRulesCore are correct for this.

@devmotion
Copy link
Member Author

Why didn't CI fail there?

Because tests used ChainRulesCore 0.9.45 which only deprecates DoesNotExist: e.g., https://github.com/JuliaMath/SpecialFunctions.jl/runs/2718082508#step:6:97

@devmotion
Copy link
Member Author

Tests on master and in other PRs use ChainRulesCore 0.10 in which DoesNotExist is not defined anymore.

@giordano
Copy link
Member

giordano commented Jun 2, 2021

I take this is good to go? I'm going to merge as soon as CI finishes

@devmotion
Copy link
Member Author

devmotion commented Jun 2, 2021

Can you also make a new release? I already updated the version number.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #327 (101f88f) into master (04ae807) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   92.70%   92.74%   +0.03%     
==========================================
  Files          12       12              
  Lines        2645     2645              
==========================================
+ Hits         2452     2453       +1     
+ Misses        193      192       -1     
Flag Coverage Δ
unittests 92.74% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/chainrules.jl 100.00% <100.00%> (ø)
src/beta_inc.jl 90.99% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26acc96...101f88f. Read the comment docs.

@giordano giordano merged commit f67c0f6 into JuliaMath:master Jun 2, 2021
@devmotion devmotion deleted the dw/doesnotexist branch June 2, 2021 21:05
@oxinabox
Copy link
Contributor

oxinabox commented Jun 2, 2021

Tests on master and in other PRs use ChainRulesCore 0.10 in which DoesNotExist is not defined anymore.

Bother. I thought I checked that it actually updated.
I wonder why it didn't.
Given nothing has changed in Compat for this PR and now it is updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants