-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DoesNotExist
with NoTangent
#327
Conversation
@oxinabox should one update the lower bounds of ChainRulesCore and/or ChainRulesTestUtils? I lost a bit track of when the different deprecations were introduced and removed. |
Because tests used ChainRulesCore 0.9.45 which only deprecates |
Tests on master and in other PRs use ChainRulesCore 0.10 in which |
I take this is good to go? I'm going to merge as soon as CI finishes |
Can you also make a new release? I already updated the version number. |
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 92.70% 92.74% +0.03%
==========================================
Files 12 12
Lines 2645 2645
==========================================
+ Hits 2452 2453 +1
+ Misses 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Bother. I thought I checked that it actually updated. |
Tests pass successfully locally with this PR.