use new ChainRulesCore #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 92.70% 92.62% -0.08%
==========================================
Files 12 12
Lines 2645 2645
==========================================
- Hits 2452 2450 -2
- Misses 193 195 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
devmotion
approved these changes
Jun 1, 2021
stevengj
approved these changes
Jun 1, 2021
|
Can this please be merged and a release tagged, this is blocking updating other packages |
This was referenced Jun 2, 2021
bors bot
added a commit
to FluxML/Zygote.jl
that referenced
this pull request
Jun 2, 2021
985: Update ChainRules and ChainRulesCore r=oxinabox a=oxinabox Replaces #983 and #984 doing both at once. We should wait for JuliaMath/SpecialFunctions.jl#319 to be merged first though as without that SpecialFunctions.jl holds us back to ChainRulesCore 0.9 which means CI will not actually tell us Co-authored-by: Lyndon White <lyndon.white@invenialabs.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares for the new ChainRulesCore release.
In this case it is mutually compatible with one of the prior releases.
Moving to 0.7 will close #310
CI will likely fail til everything is tagged, should be all working no later than tomorrow