Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jll_init job should use the name from meta.json #485

Closed
giordano opened this issue Feb 9, 2020 · 0 comments · Fixed by #486
Closed

jll_init job should use the name from meta.json #485

giordano opened this issue Feb 9, 2020 · 0 comments · Fixed by #486
Labels
bug 🐛 Something isn't working meta 🌳 Issues and pull requested related to Yggdrasil itself

Comments

@giordano
Copy link
Member

giordano commented Feb 9, 2020 •
edited
Loading

jll_init is using the environment variable NAME to initialise the repo

Yggdrasil/azure-pipelines.yml

Lines 135 to 141 in 417371d

- script: |
$(JULIA) -e "using BinaryBuilder, Pkg; \
name = \"${NAME}\"; \
BinaryBuilder.init_jll_package(name, \
joinpath(Pkg.devdir(), string(name, \"_jll\")), \
string(\"JuliaBinaryWrappers/\", name, \"_jll.jl\") \
)"

which is derived from the directory where the build_tarballs.jl script is, but I think it should use instead the name of the project as it is saved in the corresponding JSON file.

This issue caused this build to fail after creating a repo called Sundials-5_jll.jl.

CC: @staticfloat
@giordano giordano added bug 🐛 Something isn't working meta 🌳 Issues and pull requested related to Yggdrasil itself labels Feb 9, 2020
This was referenced Feb 9, 2020
Merged
Merged
Merged
ViralBShah referenced this issue Feb 11, 2020
@ViralBShah @jd-lara @giordano
Sundials 5.1 build (and co-exist with Sundials 3 build) (#461)
417371d 
* Creating a separate directory for Sundials 5.

This is basically the work of @jd-lara and @giordano in #421

Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu>

* [Sundials@5] Use gfortran & Co. only as lapack libraries

Co-authored-by: Jose Daniel Lara <jdlara@berkeley.edu>
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
@ViralBShah ViralBShah mentioned this issue Feb 11, 2020
Merged
@giordano giordano mentioned this issue Feb 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working meta 🌳 Issues and pull requested related to Yggdrasil itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AZP] Initialise JLL package from the JSON dump giordano/Yggdrasil
1 participant
@giordano