Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuiteSparse] Delete extra SuiteSparse libraries on Windows #487

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Conversation

ViralBShah
Copy link
Member

Fix #7

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix #7
@ViralBShah
Copy link
Member Author

Is there a way to inspect the contents of the CI produced windows tarball?

@giordano
Copy link
Member

Looks ok:

products/SuiteSparse.v5.4.0.i686-w64-mingw32% ls bin 
libamd.dll  libcamd.dll     libcholmod.dll  libklu.dll  librbio.dll  libsuitesparseconfig.dll    libumfpack.dll
libbtf.dll  libccolamd.dll  libcolamd.dll   libldl.dll  libspqr.dll  libsuitesparse_wrapper.dll

However note that we're not installing the license:

┌ Warning: Unable to find valid license file in "${prefix}/share/licenses/SuiteSparse"
└ @ BinaryBuilder /depot/packages/BinaryBuilder/xbKKQ/src/Auditor.jl:416

Please, don't merge this, registration won't work until #485 is fixed

@ViralBShah
Copy link
Member Author

Btw, there is no reason for this to be called SuiteSparse@5. Can I rename it to SuiteSparse, since the old one has been removed?

@ViralBShah
Copy link
Member Author

There's a LICENSE.txt in the root directory. I thought it used to get automatically picked up in the past.

https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/master/LICENSE.txt

@giordano
Copy link
Member

Btw, there is no reason for this to be called SuiteSparse@5. Can I rename it to SuiteSparse, since the old one has been removed?

If we aren't going to support other versions at the same time probably yes

I thought it used to get automatically picked up in the past.

The logic to automatically install the license file is the following: if under /workspace there is only one directory, or at most two one of which is called patches, then install all files with a sensible name.

Here under /workspace there are three directories because there is also the wrapper, so the license is not automatically installed

@ViralBShah
Copy link
Member Author

Ok, I'm going to remove the @5 and also fix the license file.

install_license for suitesparse
@ViralBShah
Copy link
Member Author

@giordano ok to merge?

@ViralBShah ViralBShah changed the title Delete extra SuiteSparse libraries on Windows [SuiteSparse] Delete extra SuiteSparse libraries on Windows Feb 10, 2020
@ViralBShah ViralBShah merged commit 04abaa7 into master Feb 10, 2020
@ViralBShah ViralBShah deleted the vs/7 branch February 10, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Win32 SuiteSparse build is subtly borked
2 participants