Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sundials@5] Resubmit Sundials build #489

Merged
merged 1 commit into from
Feb 11, 2020
Merged

[Sundials@5] Resubmit Sundials build #489

merged 1 commit into from
Feb 11, 2020

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Feb 10, 2020

Trying the suggestion from LLNL/sundials#29 for fixing windows build.
Remove gcc preferred version.

@ViralBShah ViralBShah changed the title Try upstream suggested way of fixing the windows build [Sundials] Try upstream suggested way of fixing the windows build Feb 10, 2020
@ViralBShah ViralBShah changed the title [Sundials] Try upstream suggested way of fixing the windows build [Sundials] Resubmit Sundials build Feb 11, 2020
@ViralBShah
Copy link
Member Author

Upstream suggested fix for windows does not work, so we are retaining the same fix from earlier.

https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=1498&view=logs&j=0c8f16f8-c0df-5cf3-8178-b591b90f12cf&t=fdd4b889-5821-506e-6c2a-64b809c5b85c&l=3913

@ViralBShah ViralBShah changed the title [Sundials] Resubmit Sundials build [Sundials@5] Resubmit Sundials build Feb 11, 2020
@ViralBShah
Copy link
Member Author

cc @jd-lara

Hoping this one goes through now that #485 is fixed.

@giordano
Copy link
Member

We really need GCC v6: #421 (comment)

@ViralBShah
Copy link
Member Author

Since ppc is using -lgomp, do we not need CompilerSupportLibraries?

@ViralBShah ViralBShah merged commit 9c4b543 into master Feb 11, 2020
@ViralBShah ViralBShah deleted the vs/sundials-win branch February 11, 2020 14:42
@ViralBShah
Copy link
Member Author

@giordano This didn't seem to get uploaded here: https://github.com/JuliaBinaryWrappers/Sundials-5_jll.jl

@giordano
Copy link
Member

That's the wrong repository anyway, but we still have problems: #488 (comment)

@ViralBShah
Copy link
Member Author

Ok, where should I look when the bugs are all squashed?

@giordano
Copy link
Member

I've opened #497 to track this last issue

@ViralBShah
Copy link
Member Author

ViralBShah commented Feb 18, 2020

I wiped my .julia and installed everything again. This is still broken:

julia> using Sundials_jll
[ Info: Precompiling Sundials_jll [fb77eaff-e24c-56d4-86b1-d163f2edb164]
ERROR: LoadError: LoadError: InitError: could not load library "C:\Users\viral\.julia\artifacts\bc235f981126068329fbf3f9f58f57ae63827269\bin\libspqr.dll"
The specified procedure could not be found.

@giordano
Copy link
Member

@ViralBShah
Copy link
Member Author

ViralBShah commented Feb 18, 2020

Is it possible that the libcholmod that is being picked up by libspqr is the one from Julia system install and not the one from SuiteSparse_jll? I wish we could stop doing two separate SuiteSparse builds - one for base Julia without metis and one for use by packages that is built with metis.

@ViralBShah
Copy link
Member Author

@giordano Hah just saw your comment.

@giordano
Copy link
Member

Is it possible that the libcholmod that is being picked up by libspqr is the one from Julia system install and not the one from SuiteSparse_jll?

Yes, that was my conclusion in the comment linked above 😉

@ViralBShah
Copy link
Member Author

In #548 I have disabled METIS linking in SuiteSparse for now due to the very special kinds of issues that will only be possible to resolve once SuiteSparse is not shipped in stdlib.

I think this should fix the Sundials issue on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants