Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set compat bounds for HDF5_jll for all direct users of HDF5_jll [skip build] #6707

Merged
merged 2 commits into from
May 24, 2023

Conversation

eschnett
Copy link
Contributor

@eschnett eschnett commented May 5, 2023

No description provided.

@eschnett eschnett mentioned this pull request May 5, 2023
@eschnett
Copy link
Contributor Author

eschnett commented May 8, 2023

@giordano I want to add compat bounds for all direct HDF5_jll dependencies. This PR fails because it tries to build all packages, and this fails because some use old-ish recipes. I see that @mkitti use a "skip build" directive to avoid re-building everything. However, my [skip build] annotation is apparently being ignored. How do I do this correctly?

@mkitti
Copy link
Contributor

mkitti commented May 8, 2023

Your commit message does not say skip build.

@giordano
Copy link
Member

giordano commented May 8, 2023

Yes, [skip build] should be in the commit message, whatever is written in the github page (title, messages) doesn't matter. Also, ArchiveSource calls are evaluated before checking the presence for [skip build], I recommend dealing with those packages separately.

mkitti added a commit to mkitti/Yggdrasil that referenced this pull request May 23, 2023
mkitti added a commit to mkitti/Yggdrasil that referenced this pull request May 23, 2023
giordano pushed a commit that referenced this pull request May 23, 2023
* [HDF5] Compat to ~1.12, Cherry-pick #6707, [skip build]

* Fix unintended changes, [skip build]

[skip ci]
@giordano giordano enabled auto-merge (squash) May 23, 2023 22:59
@giordano giordano merged commit d995ccc into JuliaPackaging:master May 24, 2023
@eschnett eschnett deleted the eschnett/hdf5-compat-bounds branch May 26, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants