[NetCDF] Set compat bounds for HDF5_jll up to patch, ~1.12.2 [skip build] #6790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkitti
changed the title
giordano
reviewed
May 24, 2023
S/SZ/build_tarballs.jl
Outdated
| @@ -80,7 +80,8 @@ dependencies = [ | |||
| platforms=filter(!Sys.isbsd, platforms)), | |||
| Dependency(PackageSpec(name="LLVMOpenMP_jll", uuid="1d63c593-3942-5779-bab2-d838dc0a180e"); | |||
| platforms=filter(Sys.isbsd, platforms)), | |||
| Dependency("HDF5_jll"; platforms=hdf5_platforms), | |||
| # Updating to a newer HDF5 version is likely possible without problems but requires rebuilding this package | |||
giordano
reviewed
May 24, 2023
| @@ -98,7 +98,7 @@ products = [ | |||
|
|
|||
| # Dependencies that must be installed before this package can be built | |||
| dependencies = [ | |||
| Dependency(PackageSpec(name="HDF5_jll"), compat="~1.12"), | |||
| Dependency(PackageSpec(name="HDF5_jll"), compat="~1.12.2"), | |||
There was a problem hiding this comment.
This is is different. 3fbc357 changed the compat to ~1.12. Here we change the compat to ~1.12.2 which I think is needed for NetCDF_jll to function correctly.
mkitti
force-pushed
the
mkitti/sz-hdf5-compat-bounds
branch
from
b9c1f31
to
5717df3
Compare
mkitti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set compat bounds for HDF5_jll
NetCDF_jll probably should be ~1.12.2 unless established otherwise
Otherwise, this hould finish out the diff for #6707 except that I skip build.