[Qt6Base] Upgrade to OpenSSL 3 #7619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not exactly sure if this is the correct fix? Fixes JuliaPackaging#7531.
giordano
requested changes
Nov 2, 2023
|
Okay, well we're a couple of versions behind (6.5.3 and 6.6.0 are both available: https://download.qt.io/archive/qt/), so should we just update those? |
|
Yup, that'd do it. |
giordano
reviewed
Nov 2, 2023
|
Okay, no idea if this is the right way to do this. @barche does this look right? |
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
|
okay, i'm out of ideas... |
|
I’m away from my computers until Sunday, but 6.5.3 is the right version to choose, going to 6.6 would require rebuilding GR. |
|
Looks like the new version requires some extra patching to deal with the AVX stuff. |
|
thanks @barche! |
giordano
approved these changes
Nov 5, 2023
|
I assume it's unintentional that this removes everything but x64 linux musl? JuliaBinaryWrappers/Qt6Base_jll.jl@382b0ad |
|
OK I saw #7628 (comment) |
amontoison
pushed a commit
to amontoison/Yggdrasil
that referenced
this pull request
Nov 27, 2023
* [Qt6Base] Upgrade to OpenSSL 3 I'm not exactly sure if this is the correct fix? Fixes JuliaPackaging#7531. * Update build_tarballs.jl * Update Q/Qt6Base/build_tarballs.jl Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com> * Update build_tarballs.jl * Fix haswell error --------- Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com> Co-authored-by: Bart Janssens <bart@bartjanssens.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure if this is the correct fix?
Fixes #7531.
cc: @barche