-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Qt6Base] Targets build for v6.3.5 #7628
Conversation
I just realized that the host-then-target build sequence temporarily breaks GR in minor point upgrades like this, since QtBase 6.5.3 is already in the registry but only for x64 MUSL. |
Windows is failing because CMake can't find OpenSSL, I have no immediate idea on how to fix this, maybe someone else encountered this before using OpenSSL 3? CC @giordano |
Removing I think this should still pick up our openssl at runtime, and if not and someone complains (I don't think anyone is actually using the SSL-dependent Qt classes from within Julia) we can try to find a better fix. |
Feel free to merge if this builds and if you approve @giordano |
This reverts commit 814ea18.
Import libraries of openssl on x86_64 win are in Yggdrasil/C/CyrusSASL/build_tarballs.jl Lines 46 to 49 in b524ac3
|
Also, why don't we hit ccache here? Rebuilds with what should be warm cache take way too long. |
Yggdrasil/Q/Qt6Base/build_tarballs.jl Line 181 in bca4972
|
I found #2856 (comment) but I don't think we should use LLVM_full_jll, but rather the compiler-rt stuff. Also, that'd be macos-only, it isn't needed on all platforms. |
Continuing discussion in PR #7629 |
* [Qt6Base] Targets build for v6.3.5 * Fix host LD_LIBRARY_PATH * Don't link OpenSSL on Windows * [Qt6Base] Adjust LDFLAGS for x86_64 win * Revert "[Qt6Base] Adjust LDFLAGS for x86_64 win" This reverts commit 814ea18. --------- Co-authored-by: Mosè Giordano <mose@gnu.org>
CC @simonbyrne