Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt6Base] Targets build for v6.3.5 #7628

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

barche
Copy link
Contributor

@barche barche commented Nov 5, 2023

@barche
Copy link
Contributor Author

barche commented Nov 5, 2023

I just realized that the host-then-target build sequence temporarily breaks GR in minor point upgrades like this, since QtBase 6.5.3 is already in the registry but only for x64 MUSL.

@barche
Copy link
Contributor Author

barche commented Nov 5, 2023

Windows is failing because CMake can't find OpenSSL, I have no immediate idea on how to fix this, maybe someone else encountered this before using OpenSSL 3? CC @giordano

@barche
Copy link
Contributor Author

barche commented Nov 5, 2023

Removing -openssl-linked on mingw is the only thing I can think of right now. For context, see: https://doc.qt.io/qt-6/ssl.html#enabling-and-disabling-ssl-support-when-building-qt-from-source

I think this should still pick up our openssl at runtime, and if not and someone complains (I don't think anyone is actually using the SSL-dependent Qt classes from within Julia) we can try to find a better fix.

@barche
Copy link
Contributor Author

barche commented Nov 5, 2023

Feel free to merge if this builds and if you approve @giordano

@giordano giordano marked this pull request as draft November 6, 2023 00:20
@giordano giordano marked this pull request as ready for review November 6, 2023 00:20
@giordano giordano enabled auto-merge (squash) November 6, 2023 00:39
@giordano giordano merged commit bca4972 into JuliaPackaging:master Nov 6, 2023
28 checks passed
@giordano
Copy link
Member

giordano commented Nov 6, 2023

Import libraries of openssl on x86_64 win are in ${prefix}/lib64 instead of ${prefix}/lib, but setting LDFLAGS like in

if [[ "${target}" == x86_64-* ]]; then
# On x86_64 mingw32 the import libraries of OpenSSL are in `lib64/`.
export LDFLAGS="-L${prefix}/lib64"
fi
doesn't seem to help here. I don't think I'll have much time to debug this, also because Qt build system is incredibly messed up and I'm not familiar with it, but in general we should have a better way to deal with this upgrades. Why not doing the native build in all builds? It's wasteful, but at least we don't have the problem of having broken packages between updates.

@giordano
Copy link
Member

giordano commented Nov 6, 2023

Also, why don't we hit ccache here? Rebuilds with what should be warm cache take way too long.

@giordano
Copy link
Member

giordano commented Nov 6, 2023

BuildDependency(PackageSpec(name="LLVM_full_jll", version=llvm_version)),
what is LLVM needed for?

@giordano
Copy link
Member

giordano commented Nov 6, 2023

I found #2856 (comment) but I don't think we should use LLVM_full_jll, but rather the compiler-rt stuff. Also, that'd be macos-only, it isn't needed on all platforms.

@barche
Copy link
Contributor Author

barche commented Nov 6, 2023

Continuing discussion in PR #7629

@barche barche deleted the qt6.5.3-targets branch November 11, 2023 09:43
amontoison pushed a commit to amontoison/Yggdrasil that referenced this pull request Nov 27, 2023
* [Qt6Base] Targets build for v6.3.5

* Fix host LD_LIBRARY_PATH

* Don't link OpenSSL on Windows

* [Qt6Base] Adjust LDFLAGS for x86_64 win

* Revert "[Qt6Base] Adjust LDFLAGS for x86_64 win"

This reverts commit 814ea18.

---------

Co-authored-by: Mosè Giordano <mose@gnu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants