T8code 3.0.0 #9718
Merged
T8code 3.0.0 #9718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green! Please merge if you agree. |
giordano
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Should this patch be upstreamed?
There was a problem hiding this comment.
I opened issues upstream.
cburstedde/libsc#206
cburstedde/p4est#322
I am not sure what exactly the problem is. The patches are results via trial-and-error and specifically tailored for getting t8code compiled on MinGW in the Yggdrasil resp. BinaryBuilder context.
From past experience, merging patches to the aforementioned libraries takes a very long time.
I appreciate if this workaround is accepted for now, so I can move on with providing a much needed update to T8code.jl.
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
t8code_jllto the most recent version of t8code: 3.0.0.Additionally, the build recipe switched from autotools to CMake for configuring and building t8code.