-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T8code 3.0.0 #9718
Merged
Merged
T8code 3.0.0 #9718
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
diff --git a/sc/CMakeLists.txt b/sc/CMakeLists.txt | ||
index 9ebf6efb..7ce1038a 100644 | ||
--- a/sc/CMakeLists.txt | ||
+++ b/sc/CMakeLists.txt | ||
@@ -51,7 +51,6 @@ $<$<BOOL:${SC_ENABLE_MPI}>:MPI::MPI_C> | ||
$<$<BOOL:${SC_HAVE_ZLIB}>:ZLIB::ZLIB> | ||
$<$<BOOL:${SC_HAVE_JSON}>:jansson::jansson> | ||
$<$<BOOL:${SC_NEED_M}>:m> | ||
-$<$<BOOL:${WIN32}>:${WINSOCK_LIBRARIES}> | ||
) | ||
|
||
# imported target, for use from parent project |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
diff --git a/p4est/CMakeLists.txt b/p4est/CMakeLists.txt | ||
index ca73876c..70bd62b3 100644 | ||
--- a/p4est/CMakeLists.txt | ||
+++ b/p4est/CMakeLists.txt | ||
@@ -46,7 +46,12 @@ target_include_directories(p4est PUBLIC | ||
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/src> | ||
$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include> | ||
$<INSTALL_INTERFACE:include>) | ||
-target_link_libraries(p4est PUBLIC SC::SC $<$<BOOL:${P4EST_HAVE_WINSOCK2_H}>:${WINSOCK_LIBRARIES}>) | ||
+ | ||
+if(WIN32) | ||
+ target_link_libraries(p4est PUBLIC SC::SC wsock32 ws2_32) | ||
+else() | ||
+ target_link_libraries(p4est PUBLIC SC::SC) | ||
+endif() | ||
|
||
# imported target, for use from parent projects | ||
add_library(P4EST::P4EST INTERFACE IMPORTED GLOBAL) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this patch be upstreamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened issues upstream.
cburstedde/libsc#206
cburstedde/p4est#322
I am not sure what exactly the problem is. The patches are results via trial-and-error and specifically tailored for getting t8code compiled on MinGW in the Yggdrasil resp. BinaryBuilder context.
From past experience, merging patches to the aforementioned libraries takes a very long time.
I appreciate if this workaround is accepted for now, so I can move on with providing a much needed update to T8code.jl.