Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: AWSCore v0.6.10 #12973

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 4f1ea46c-232b-54a6-9b17-cc2d0f3e6598
Repo: https://github.com/JuliaCloud/AWSCore.jl.git
Tree: e4aeca728228cc18ed0cd7a72ad7e8edaf8551ba

Registrator tree SHA: unknown
JuliaRegistrator referenced this pull request in JuliaCloud/AWSCore.jl Apr 14, 2020
116: Return both body and header for all AWS requests r=mattBrzezinski a=mattBrzezinski

`AWSS3.jl` is having issues where the multi-part upload is not working properly, it attempts to return request headers back as both the `part number` and `etag` are required to successfully complete a multi-part upload.

`AWSCore.jl` currently does not return headers unless the operation is a `HEAD` type request. This merge request returns back the response `body` and `headers` for all requests, which accommodates for these requirements.

This change will allow use to begin resolving [AWSS3.jl #84](JuliaCloud/AWSS3.jl#84).

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
Co-authored-by: Matt.jl <matt.brzezinski@invenia.ca>
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@github-actions github-actions bot merged commit fba99e2 into master Apr 14, 2020
@github-actions github-actions bot deleted the registrator/awscore/4f1ea46c/v0.6.10 branch April 14, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant