Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hasOrphans isFullyConnected #325

Closed
Affie opened this issue Feb 21, 2020 · 2 comments · Fixed by #427
Closed

Refactor hasOrphans isFullyConnected #325

Affie opened this issue Feb 21, 2020 · 2 comments · Fixed by #427
Assignees
Milestone

Comments

@Affie
Copy link
Member

Affie commented Feb 21, 2020

Clean/clear up connectivity functions, isFullyConnected and hasOrphans

For clearer understanding of exactly what the function does:
Deprecate:

  • isFullyConnected
  • hasOrphans

In favor of:

  • isFragmented or similar

Add functionality:

  • isFactorsFullyConnected
@Affie Affie added this to the v0.6.x milestone Feb 21, 2020
@Affie Affie modified the milestones: v0.7.x, v0.8.x, v0.7.6 May 1, 2020
@Affie
Copy link
Member Author

Affie commented May 1, 2020

Since orphaned factors aren't currently allowed reserve isFactorsFullyConnected for future use.

A definition:

a graph G is connected if there is a path between each pair of vertices

  • use name isConnected
    deprecate:
  • hasOrphans - is misleading in the current implementation
  • isFullyConnected - what does the fully imply, if we want to allow orphaned factors in the future does the fully mean all links that should be there is there?

@Affie Affie self-assigned this May 1, 2020
Affie added a commit that referenced this issue May 1, 2020
@Affie
Copy link
Member Author

Affie commented May 2, 2020

We can also do isDisconnected = !isConnected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant