Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hasOrphans and isFullyConnected to isConnected #427

Merged
merged 1 commit into from
May 2, 2020

Conversation

Affie
Copy link
Member

@Affie Affie commented May 1, 2020

close #325

@Affie Affie added this to the v0.7.6 milestone May 1, 2020
@Affie Affie requested review from GearsAD and dehann May 1, 2020 18:44
@Affie Affie changed the title refactor isConnected Rename hasOrphans and isFullyConnected to isConnected May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #427 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   85.90%   85.89%   -0.01%     
==========================================
  Files          36       36              
  Lines        1951     1950       -1     
==========================================
- Hits         1676     1675       -1     
  Misses        275      275              
Impacted Files Coverage Δ
src/CloudGraphsDFG/services/CloudGraphsDFG.jl 87.25% <ø> (ø)
src/Deprecated.jl 67.01% <ø> (ø)
src/DistributedFactorGraphs.jl 100.00% <ø> (ø)
src/GraphsDFG/GraphsDFG.jl 100.00% <ø> (ø)
src/GraphsDFG/services/GraphsDFG.jl 93.85% <ø> (ø)
src/LightDFG/LightDFG.jl 100.00% <ø> (ø)
src/LightDFG/services/LightDFG.jl 90.83% <100.00%> (ø)
src/services/AbstractDFG.jl 95.05% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ff1b6...29b6e7e. Read the comment docs.

Copy link
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@dehann dehann merged commit 37bb5f4 into master May 2, 2020
@Affie Affie deleted the maint/20Q2/isConnected branch August 31, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor hasOrphans isFullyConnected
2 participants