Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer checking breaks buffer re-use #313

Closed
fredrikekre opened this issue Dec 8, 2022 · 0 comments · Fixed by #314
Closed

Buffer checking breaks buffer re-use #313

fredrikekre opened this issue Dec 8, 2022 · 0 comments · Fixed by #314

Comments

@fredrikekre
Copy link
Member

JuliaLang/julia#40523 introduced buffer checks in the inner constructor which breaks this code:

using SparseArrays

Tv, Ti = Float64, Int
I = Ti[1, 1, 2, 3]
J = Ti[1, 1, 2, 3]
V = zeros(Tv, length(I))
m, n = 3, 3
klasttouch = Vector{Ti}(undef, n)
csrrowptr = Vector{Ti}(undef, m + 1)
csrcolval = Vector{Ti}(undef, length(I))
csrnzval = Vector{Tv}(undef, length(I))

SparseArrays.sparse!(
    I, J, V, m, n, +,
    klasttouch,
    csrrowptr, csrcolval, csrnzval,
    I, J, V
)

Since it seems that we have now settled on not allowing longer buffer vectors the fix seems to automatically resize the vectors, and document that?
fredrikekre added a commit that referenced this issue Dec 9, 2022
@fredrikekre
Resize buffers in sparse! to satisfy buffer checks in constructor
4240f1b 
With this patch the output buffers to `sparse!` are resized in order to
satisfy the buffer length checks in the `SparseMatrixCSC` constructor
that were introduced in JuliaLang/julia#40523. Previously `csccolptr`
was never resized, and  `cscrowval` and `cscnzval` were only resized if
the buffers were too short (i.e. never truncated).

The requirement `length(csccolptr) >= n + 1` could be kept, but seems
unnecessary since all buffers need to be resized anyway (to pass the
constructor checks).

In particular this fixes calling `sparse!` with `I`, `J`, `V` as both
input and output buffers: `sparse!(I, J, V, m, n, ..., I, J, V)`.

Fixes #313.
@fredrikekre fredrikekre mentioned this issue Dec 9, 2022
Merged
fredrikekre added a commit that referenced this issue Dec 9, 2022
@fredrikekre
Resize buffers in sparse! to satisfy buffer checks in constructor
40e989c 
With this patch the output buffers to `sparse!` are resized in order to
satisfy the buffer length checks in the `SparseMatrixCSC` constructor
that were introduced in JuliaLang/julia#40523. Previously `csccolptr`
was never resized, and  `cscrowval` and `cscnzval` were only resized if
the buffers were too short (i.e. never truncated).

The requirement `length(csccolptr) >= n + 1` could be kept, but seems
unnecessary since all buffers need to be resized anyway (to pass the
constructor checks).

In particular this fixes calling `sparse!` with `I`, `J`, `V` as both
input and output buffers: `sparse!(I, J, V, m, n, ..., I, J, V)`.

Fixes #313.
fredrikekre added a commit that referenced this issue Dec 12, 2022
@fredrikekre
Resize buffers in sparse! to satisfy buffer checks in constructor (#…
85a381b 
…314)

With this patch the output buffers to `sparse!` are resized in order to
satisfy the buffer length checks in the `SparseMatrixCSC` constructor
that were introduced in JuliaLang/julia#40523. Previously `csccolptr`
was never resized, and  `cscrowval` and `cscnzval` were only resized if
the buffers were too short (i.e. never truncated).

The requirement `length(csccolptr) >= n + 1` could be kept, but seems
unnecessary since all buffers need to be resized anyway (to pass the
constructor checks).

In particular this fixes calling `sparse!` with `I`, `J`, `V` as both
input and output buffers: `sparse!(I, J, V, m, n, ..., I, J, V)`.

Fixes #313.
fredrikekre added a commit that referenced this issue Dec 12, 2022
@fredrikekre
Resize buffers in sparse! to satisfy buffer checks in constructor (#…
9a75135 
…314)

With this patch the output buffers to `sparse!` are resized in order to
satisfy the buffer length checks in the `SparseMatrixCSC` constructor
that were introduced in JuliaLang/julia#40523. Previously `csccolptr`
was never resized, and  `cscrowval` and `cscnzval` were only resized if
the buffers were too short (i.e. never truncated).

The requirement `length(csccolptr) >= n + 1` could be kept, but seems
unnecessary since all buffers need to be resized anyway (to pass the
constructor checks).

In particular this fixes calling `sparse!` with `I`, `J`, `V` as both
input and output buffers: `sparse!(I, J, V, m, n, ..., I, J, V)`.

Fixes #313.

(cherry picked from commit 85a381b)
fredrikekre added a commit that referenced this issue Dec 12, 2022
@fredrikekre
Resize buffers in sparse! to satisfy buffer checks in constructor (#…
747c67f 
…314)

With this patch the output buffers to `sparse!` are resized in order to
satisfy the buffer length checks in the `SparseMatrixCSC` constructor
that were introduced in JuliaLang/julia#40523. Previously `csccolptr`
was never resized, and  `cscrowval` and `cscnzval` were only resized if
the buffers were too short (i.e. never truncated).

The requirement `length(csccolptr) >= n + 1` could be kept, but seems
unnecessary since all buffers need to be resized anyway (to pass the
constructor checks).

In particular this fixes calling `sparse!` with `I`, `J`, `V` as both
input and output buffers: `sparse!(I, J, V, m, n, ..., I, J, V)`.

Fixes #313.

(cherry picked from commit 85a381b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resize buffers in sparse! to satisfy buffer checks in constructor JuliaSparse/SparseArrays.jl
1 participant
@fredrikekre