Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

show methods broken on latest master #96

Closed
davidagold opened this issue Jan 2, 2016 · 1 comment
Closed

show methods broken on latest master #96

davidagold opened this issue Jan 2, 2016 · 1 comment

Comments

@davidagold
Copy link
Contributor

I imagine the culprit is JuliaLang/julia#13825.

The most immediate breakage point is reliance on a no longer extant Base.alignment method. I haven't had a chance to look thoroughly at all the api changes in the above PR, but I suspect there may be deeper breakage points.

Issues like this draw attention to the unsatisfactory state of the current show scheme for NullableArray objects. In the future I'd like to rely on a more self-contained scheme less susceptible to breakage from changes in Base's internal apis.

davidagold added a commit that referenced this issue Jan 16, 2016
Issue caused by changes to alignment and related method signatures in the following PR: JuliaLang/julia#13825
davidagold added a commit that referenced this issue Jan 17, 2016
Issue caused by changes to alignment and related method signatures in the
following PR: JuliaLang/julia#13825
davidagold added a commit that referenced this issue Jan 17, 2016
Issue caused by changes to alignment and related method signatures in the
following PR: JuliaLang/julia#13825
davidagold added a commit that referenced this issue Jan 17, 2016
Issue caused by changes to alignment and related method signatures in the
following PR: JuliaLang/julia#13825
davidagold added a commit that referenced this issue Jan 17, 2016
Issue caused by changes to alignment and related method signatures in the
following PR: JuliaLang/julia#13825
davidagold added a commit that referenced this issue Jan 17, 2016
@davidagold
Copy link
Contributor Author

Fixed with #97

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant