Refactor email signup on NoRent footer to use new API #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sraby
commented
Jun 24, 2020
toolness
requested changes
Jun 24, 2020
|
sorry about the change @toolness! I can still see all of your comments luckily. |
|
Oh and I wouldn't worry about the CodeClimate stuff for now--I think it should be addressed eventually but I think there are lots of ways to do that, including factoring out a separate module that does a bunch of the repetitive logic from all 3 of our uses for us, and has a thorough test suite... So we can file an issue to deal with it later! |
added 2 commits
June 24, 2020 17:45
toolness
approved these changes
Jun 24, 2020
|
Nice, this looks great, feel free to merge! |
toolness
reviewed
Jun 24, 2020
Comment on lines
+17
to
+18
| <SimpleProgressiveEnhancement> | ||
| <> |
There was a problem hiding this comment.
Oof, we should really change this component to accept multiple JSX elements as children. Filed #1560 to address this later.
This was referenced Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reconfigures the email sign-up form at the footer of NoRent.org to make use of the Mailchimp CORS endpoint included in #1549.