-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor email signup on NoRent footer to use new API #1556
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
74f5a81
added preliminary scaffolding for new email signup form
c1230cb
fixed fetch url Issue
ec0c73f
refactored subscribe component to use react hooks
81c532a
addressed changes from code review
9b66f51
hard coded spanish translations
cf0f9e6
prettier
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| import React, { useState } from "react"; | ||
| import { Trans, t } from "@lingui/macro"; | ||
| import { li18n } from "../../i18n-lingui"; | ||
| import { StaticImage } from "../../ui/static-image"; | ||
| import { getImageSrc } from "../homepage"; | ||
| import { AriaAnnouncement } from "../../ui/aria"; | ||
| import { awesomeFetch } from "../../networking/fetch"; | ||
|
|
||
| const Subscribe = () => { | ||
| const [email, setEmail] = useState(""); | ||
| const [isSuccessful, setSuccess] = useState(false); | ||
| const [response, setResponse] = useState(""); | ||
|
|
||
| const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
| setEmail(e.target.value); | ||
| }; | ||
|
|
||
| const handleSubmit = (e: React.FormEvent<HTMLFormElement>) => { | ||
| e.preventDefault(); | ||
| const locale = li18n.language; | ||
|
|
||
| if (!email) { | ||
| setResponse(li18n._(t`Please enter an email address!`)); | ||
| return; | ||
| } | ||
|
|
||
| awesomeFetch("/mailchimp/subscribe", { | ||
| method: "POST", | ||
| body: `email=${encodeURIComponent( | ||
| )}&language=${locale}&source=norent`, | ||
| headers: { | ||
| "Content-Type": "application/x-www-form-urlencoded", | ||
| }, | ||
| }) | ||
| .then((result) => result.json()) | ||
| .then((result) => { | ||
| if (result.status === 200) { | ||
| setSuccess(true); | ||
| setResponse(li18n._(t`All set! Thanks for subscribing!`)); | ||
| } else if (result.errorCode === "INVALID_EMAIL") { | ||
| setResponse(li18n._(t`Oops! That email is invalid.`)); | ||
| } else { | ||
| window.Rollbar?.error( | ||
| `Mailchimp email signup responded with error code ${result.errorCode}.` | ||
| ); | ||
| setResponse( | ||
| li18n._(t`Oops! A network error occurred. Try again later.`) | ||
| ); | ||
| } | ||
| }) | ||
| .catch((err) => { | ||
| setResponse( | ||
| li18n._(t`Oops! A network error occurred. Try again later.`) | ||
| ); | ||
| }); | ||
| }; | ||
|
|
||
| return ( | ||
| <div> | ||
| <form className="email-form is-horizontal-center" onSubmit={handleSubmit}> | ||
| <div className="mc-field-group"> | ||
| <div className="control is-expanded"> | ||
| <label htmlFor="mce-EMAIL" className="jf-sr-only"> | ||
| <Trans>Email</Trans> | ||
| </label> | ||
| <input | ||
| type="email" | ||
| name="EMAIL" | ||
| className="input" | ||
| id="mce-EMAIL" | ||
| onChange={handleChange} | ||
| placeholder={li18n._(t`ENTER YOUR EMAIL`)} | ||
| /> | ||
| </div> | ||
| <div className="control has-text-centered-touch"> | ||
| <button | ||
| className="button" | ||
| type="submit" | ||
| aria-label={li18n._(t`Submit email`)} | ||
| > | ||
| <StaticImage | ||
| ratio="is-16x16" | ||
| src={getImageSrc("submitarrow")} | ||
| alt={li18n._(t`Submit email`)} | ||
| /> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </form> | ||
| {response && ( | ||
| <> | ||
| <br /> | ||
| <p className={isSuccessful ? "has-text-white" : "has-text-danger"}> | ||
| <AriaAnnouncement text={response} /> | ||
| {response} | ||
| </p> | ||
| </> | ||
| )} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Subscribe; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, we should really change this component to accept multiple JSX elements as children. Filed #1560 to address this later.